Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled <<namePrefix>> token across modules and dependency pipeline resources #945

Merged
merged 23 commits into from
Feb 1, 2022

Conversation

ahmadabdalla
Copy link
Contributor

Closes #909

Change

  • Updated Modules & Dependency pipeline parameter files to use the new <<namePrefix>> token.
  • Added token replacement for PowerShell tasks for dependency pipeline for both GH and ADO pipelines.
  • Added new pester test to detect if parameter files contain the value for the namePrefix instead of the token.
  • Added section in the getting started documentation to guide users in replacing the namePrefix token as one of the first PRs upon forking.

Testing

  • Tested ADO dependency pipeline after updating tasks. See result

  • Tested GH dependency pipeline after updating tasks. .Platform: Dependencies

  • Tested different Modules to validate tokens functionality (Storage Account, Container Registries, Service Bus Namespace)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added the [cat] pipelines category: pipelines label Jan 29, 2022
@ahmadabdalla ahmadabdalla added this to the v 0.4 milestone Jan 29, 2022
@ahmadabdalla ahmadabdalla self-assigned this Jan 29, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Unit Test Results

  1 files    1 suites   32s ⏱️
10 tests 10 ✔️   0 💤 0
76 runs  10 ✔️ 66 💤 0

Results for commit 0f7c95b.

♻️ This comment has been updated with latest results.

@ahmadabdalla ahmadabdalla marked this pull request as ready for review February 1, 2022 03:22
ahmadabdalla and others added 3 commits February 2, 2022 03:17
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
ahmadabdalla and others added 5 commits February 2, 2022 04:48
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr merged commit c13d03b into main Feb 1, 2022
@AlexanderSehr AlexanderSehr deleted the users/ahmad/tokensPrefixFeature branch February 1, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token Replacement: Using naming prefixes to support forking and instantiating the repo for CARML consumers
3 participants