Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publishing template for firewall policies in ADO #975

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Fix publishing template for firewall policies in ADO #975

merged 1 commit into from
Feb 7, 2022

Conversation

MariusStorhaug
Copy link
Contributor

Change

Fix publishing template for firewall policies in ADO

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this Feb 6, 2022
@MariusStorhaug MariusStorhaug linked an issue Feb 6, 2022 that may be closed by this pull request
Azure Firewall policy pipeline not using correct publishing template #974
Closed
@MariusStorhaug MariusStorhaug added [cat] azure devops category: Azure DevOps [cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [prio] medium importance of the issue: medium priority bug Something isn't working labels Feb 6, 2022
@MariusStorhaug MariusStorhaug added this to the v 0.4 milestone Feb 6, 2022
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) February 6, 2022 19:56
@MariusStorhaug MariusStorhaug merged commit 9cb7c2e into main Feb 7, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/#974 branch February 7, 2022 10:33
@mblant mblant added this to Needs triage in Bug board Mar 29, 2022
@mblant mblant removed this from Needs triage in Bug board Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

@rahalan rahalan Awaiting requested review from rahalan

@eriqua eriqua Awaiting requested review from eriqua

Assignees

@MariusStorhaug MariusStorhaug

Labels
bug Something isn't working [cat] azure devops category: Azure DevOps [cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [prio] medium importance of the issue: medium priority
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

Azure Firewall policy pipeline not using correct publishing template
2 participants
@MariusStorhaug @AlexanderSehr