[2.1.6] Fail to set resource disk to xfs type in RHEL-7

[yuxisun1217]

Hi,

Do we support xfs type for resource disk now? Because xfs type is the default file system type in RHEL-7.
If we want to support xfs type, it seems that mkfs.xfs command doesn't have -F option(Line128 in azurelinuxagent/daemon/resourcedisk/default.py: shellutil.run("mkfs." + fs + " " + partition + " -F")). I think we can use '-f' if the type is xfs. Thanks!

WALA version: 2.1.6
OS: RHEL-7.3 internal build

Reproduce steps:

1. Set ResourceDisk.Filesystem=xfs in waagent.conf.
2. Deprovision this VM. Capture an image. Create a new VM base on this image.

Actual Result:
Cannot format /dev/sdb1 to xfs type.
Error logs in waagent.log:
2016/08/31 16:23:55.060711 ERROR run cmd 'mkfs.xfs /dev/sdb1 -F' failed
2016/08/31 16:23:55.084195 ERROR Error Code:1
2016/08/31 16:23:55.089074 ERROR Result:mkfs.xfs: invalid option -- 'F'
unknown option -F

[yuxisun1217]

Hi @hglkrijger ,

I find that if I use xfs file system, the "swapon /mnt/resource/swapfile" command returns error:
2016/09/29 11:05:27.795097 ERROR run cmd 'swapon /mnt/resource/swapfile' failed
2016/09/29 11:05:27.821972 ERROR Error Code:255
2016/09/29 11:05:27.826900 ERROR Result:swapon: /mnt/resource/swapfile: swapon failed: Invalid argument
2016/09/29 11:05:27.848735 ERROR Failed to enable swap (000005)/mnt/resource/swapfile

I google it and find that it is because the fallocate does not physically allocate the space -- but swapon syscall requires a real space. (https://bugzilla.redhat.com/show_bug.cgi?id=1129205#c3)
So for xfs file system, perhaps we have to use "dd" instead of "fallocate". I tried "dd" and it works well on xfs file system.