fix: remove ImagePullPolicy: Always (#1046)

Signed-off-by: Ernest Wong <chuwon@microsoft.com>
Azure · Apr 16, 2021 · 9f3528f · 9f3528f
1 parent 5dbc3d9
commit 9f3528f
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 22 deletions.
diff --git a/manifest_staging/charts/aad-pod-identity/README.md b/manifest_staging/charts/aad-pod-identity/README.md
diff --git a/manifest_staging/charts/aad-pod-identity/values.yaml b/manifest_staging/charts/aad-pod-identity/values.yaml
@@ -7,7 +7,7 @@ fullnameOverride: ""
 
 image:
   repository: mcr.microsoft.com/oss/azure/aad-pod-identity
-  imagePullPolicy: Always
+  imagePullPolicy: IfNotPresent
 
 # One or more secrets to be used when pulling images
 # imagePullSecrets:
@@ -246,8 +246,8 @@ rbac:
   # If using only MSI (type: 0) in AzureIdentity, secret get permission can be disabled by setting this to false.
   allowAccessToSecrets: true
   pspEnabled: false
-  # If set to true, then view and edit cluster roles will be created with annotations 
-  # that agrigate to the admin, edit and view built-in cluster roles. These roles will 
+  # If set to true, then view and edit cluster roles will be created with annotations
+  # that agrigate to the admin, edit and view built-in cluster roles. These roles will
   # be able to create the necessary resources to allow pod identity binding on pods.
   createUserFacingClusterRoles: false
 

diff --git a/manifest_staging/deploy/demo/deployment.yaml b/manifest_staging/deploy/demo/deployment.yaml
@@ -19,7 +19,6 @@ spec:
       containers:
       - name: demo
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/demo:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--subscriptionid=SUBSCRIPTION_ID"
           - "--clientid=CLIENT_ID"

diff --git a/manifest_staging/deploy/infra/deployment-rbac.yaml b/manifest_staging/deploy/infra/deployment-rbac.yaml
@@ -452,7 +452,6 @@ spec:
       containers:
       - name: nmi
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/nmi:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--node=$(NODE_NAME)"
           - "--http-probe-port=8085"
@@ -571,7 +570,6 @@ spec:
       containers:
       - name: mic
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/mic:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--cloudconfig=/etc/kubernetes/azure.json"
           - "--logtostderr"

diff --git a/manifest_staging/deploy/infra/deployment.yaml b/manifest_staging/deploy/infra/deployment.yaml
@@ -408,7 +408,6 @@ spec:
       containers:
       - name: nmi
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/nmi:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--node=$(NODE_NAME)"
           - "--http-probe-port=8085"
@@ -472,7 +471,6 @@ spec:
       containers:
       - name: mic
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/mic:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--kubeconfig=/etc/kubernetes/kubeconfig/kubeconfig"
           - "--cloudconfig=/etc/kubernetes/azure.json"

diff --git a/manifest_staging/deploy/infra/managed-mode-deployment.yaml b/manifest_staging/deploy/infra/managed-mode-deployment.yaml
@@ -284,7 +284,6 @@ spec:
       containers:
       - name: nmi
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/nmi:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--node=$(NODE_NAME)"
           - "--operation-mode=managed"

diff --git a/manifest_staging/deploy/infra/noazurejson/deployment-rbac.yaml b/manifest_staging/deploy/infra/noazurejson/deployment-rbac.yaml
@@ -451,7 +451,6 @@ spec:
       containers:
       - name: nmi
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/nmi:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--node=$(NODE_NAME)"
           - "--http-probe-port=8085"
@@ -582,7 +581,6 @@ spec:
       containers:
       - name: mic
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/mic:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--logtostderr"
         securityContext:

diff --git a/manifest_staging/deploy/infra/noazurejson/deployment.yaml b/manifest_staging/deploy/infra/noazurejson/deployment.yaml
@@ -406,7 +406,6 @@ spec:
       containers:
       - name: nmi
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/nmi:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--node=$(NODE_NAME)"
           - "--http-probe-port=8085"
@@ -484,7 +483,6 @@ spec:
       containers:
       - name: mic
         image: "mcr.microsoft.com/oss/azure/aad-pod-identity/mic:v1.7.5"
-        imagePullPolicy: Always
         args:
           - "--kubeconfig=/etc/kubernetes/kubeconfig/kubeconfig"
           - "--logtostderr"

diff --git a/test/load/deployment-template.yml b/test/load/deployment-template.yml
@@ -21,14 +21,12 @@ spec:
       initContainers:
         - name: init
           image: mcr.microsoft.com/azure-cli
-          imagePullPolicy: IfNotPresent
           command:
             - sh
             - -c
             - az login --identity --allow-no-subscriptions && az login -i -u $POD_IDENTITY_CLIENT_ID --allow-no-subscriptions
       containers:
       - image: k8s.gcr.io/pause-amd64:3.1
-        imagePullPolicy: IfNotPresent
         name: {{.Name}}
       tolerations:
       - key: "node.kubernetes.io/not-ready"

diff --git a/website/content/en/docs/Configure/match_pods_in_namespace.md b/website/content/en/docs/Configure/match_pods_in_namespace.md
@@ -36,7 +36,6 @@ By default, AAD Pod Identity matches pods to identities across namespaces. To ma
           containers:
           - name: mic
             image: "mcr.microsoft.com/k8s/aad-pod-identity/mic:1.3"
-            imagePullPolicy: Always
             args:
               - "--cloudconfig=/etc/kubernetes/azure.json"
               - "--logtostderr"