This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Adds a default affinity rule to values.yaml #1082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewong
reviewed
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Could you make the change in manifest_staging
folder instead?
JasonWhall
force-pushed
the
add-default-affinity
branch
from
June 3, 2021 07:54
5d3417f
to
a99eea2
Compare
@chewong sure, updated! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
reviewed
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the default affinity
in the configuration table?
- Uses preferred rule instead of required to not hard fail scheduling on single node cluster
JasonWhall
force-pushed
the
add-default-affinity
branch
from
June 3, 2021 21:45
a99eea2
to
79d144d
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
chewong
approved these changes
Jun 4, 2021
aramase
approved these changes
Jun 4, 2021
statbit
pushed a commit
to adobe-platform/aad-pod-identity
that referenced
this pull request
Sep 30, 2021
- Uses preferred rule instead of required to not hard fail scheduling on single node cluster
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds a default affinity rule to values.yaml
Requirements
make precommit
Issue Fixed:
#1058
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?