Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Adds a default affinity rule to values.yaml #1082

Merged
merged 1 commit into from Jun 4, 2021

Conversation

JasonWhall
Copy link
Contributor

Reason for Change:

Adds a default affinity rule to values.yaml

  • Uses preferred rule instead of required to not hard fail scheduling on single node clusters

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable). See test standard for more details.
  • ran make precommit

Issue Fixed:

#1058

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

@ghost
Copy link

ghost commented Jun 2, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Could you make the change in manifest_staging folder instead?

@JasonWhall
Copy link
Contributor Author

@chewong sure, updated!

@aramase
Copy link
Member

aramase commented Jun 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the default affinity in the configuration table?

- Uses preferred rule instead of required to not hard fail scheduling on single node cluster
@chewong
Copy link
Contributor

chewong commented Jun 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chewong chewong requested a review from aramase June 4, 2021 20:24
@aramase aramase merged commit faf1246 into Azure:master Jun 4, 2021
@JasonWhall JasonWhall deleted the add-default-affinity branch June 5, 2021 08:12
statbit pushed a commit to adobe-platform/aad-pod-identity that referenced this pull request Sep 30, 2021
- Uses preferred rule instead of required to not hard fail scheduling on single node cluster
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants