Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

fix: add handler for invalid token requests #1325

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 28, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable). See test standard for more details.
  • ran make precommit

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1325 (c89fa17) into master (6dc82f9) will decrease coverage by 0.39%.
The diff coverage is 28.95%.

❗ Current head c89fa17 differs from pull request most recent head 450d025. Consider uploading reports for the commit 450d025 to get more accurate results

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   36.29%   35.90%   -0.40%     
==========================================
  Files          27       32       +5     
  Lines        2915     4434    +1519     
==========================================
+ Hits         1058     1592     +534     
- Misses       1778     2759     +981     
- Partials       79       83       +4     

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase marked this pull request as ready for review September 29, 2022 20:34
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@aramase aramase merged commit 7e01970 into Azure:master Oct 3, 2022
@aramase aramase deleted the token-request-backslash branch October 3, 2022 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants