Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

helm: remove deprecated forceNameSpaced from values.yaml #927

Merged
merged 1 commit into from
Jan 6, 2021
Merged

helm: remove deprecated forceNameSpaced from values.yaml #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion manifest_staging/charts/aad-pod-identity/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ The following tables list the configurable parameters of the aad-pod-identity ch
| `image.repository` | Image repository | `mcr.microsoft.com/oss/azure/aad-pod-identity` |
| `image.pullPolicy` | Image pull policy | `Always` |
| `imagePullSecrets` | One or more secrets to be used when pulling images | `[]` |
| `forceNameSpaced` (**DEPRECATED**) | By default, AAD Pod Identity matches pods to identities across namespaces. To match only pods in the namespace containing AzureIdentity set this to true. | `false` |
| `forceNamespaced` | By default, AAD Pod Identity matches pods to identities across namespaces. To match only pods in the namespace containing AzureIdentity set this to true. | `false` |
| `installMICException` | When NMI runs on a node where MIC is running, then MIC token request call is also intercepted by NMI. MIC can't get a valid token to initialize and then assign the identity. Installing an exception for MIC would ensure all token requests for MIC pods directly go to IMDS and not go through the pod-identity validation | `true` |
| `adminsecret.cloud` | Azure cloud environment name | ` ` |
Expand Down
4 changes: 0 additions & 4 deletions manifest_staging/charts/aad-pod-identity/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,4 @@ To verify that AAD Pod Identity has started in {{ .Values.operationMode }} mode,
kubectl --namespace={{ .Release.Namespace }} get pods -l "app.kubernetes.io/component=nmi"
{{ end }}

{{- if .Values.forceNameSpaced }}
forceNameSpaced configuration has been DEPRECATED and will be removed in a future release. Please use forceNamespaced instead.
{{- end }}

Now you can follow the demos to get familiar with AAD Pod Identity: https://azure.github.io/aad-pod-identity/docs/demo/
2 changes: 1 addition & 1 deletion manifest_staging/charts/aad-pod-identity/templates/mic-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ spec:
fieldRef:
fieldPath: metadata.namespace
- name: FORCENAMESPACED
value: "{{ .Values.forceNameSpaced | default .Values.forceNamespaced }}"
value: "{{ .Values.forceNamespaced }}"
{{- if .Values.adminsecret }}
- name: CLOUD
valueFrom:
Expand Down
2 changes: 1 addition & 1 deletion manifest_staging/charts/aad-pod-identity/templates/nmi-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ spec:
fieldPath: spec.nodeName
{{- if eq .Values.operationMode "standard" }}
- name: FORCENAMESPACED
value: "{{ .Values.forceNameSpaced | default .Values.forceNamespaced }}"
value: "{{ .Values.forceNamespaced }}"
{{- end }}
{{- if .Values.nmi.prometheusPort }}
ports:
Expand Down
6 changes: 0 additions & 6 deletions manifest_staging/charts/aad-pod-identity/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ image:
# imagePullSecrets:
# - name: myRegistryKeySecretName

# https://github.com/Azure/aad-pod-identity#4-optional-match-pods-in-the-namespace
# By default, AAD Pod Identity matches pods to identities across namespaces.
# To match only pods in the namespace containing AzureIdentity set this to true.
# DEPRECATED - use 'forceNamespaced' instead.
forceNameSpaced: ""

# https://github.com/Azure/aad-pod-identity#4-optional-match-pods-in-the-namespace
# By default, AAD Pod Identity matches pods to identities across namespaces.
# To match only pods in the namespace containing AzureIdentity set this to true.
Expand Down