Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The activeRevisionsMode is forcibly set to Multiple. #62

Open
k-in opened this issue Sep 22, 2022 · 14 comments
Open

The activeRevisionsMode is forcibly set to Multiple. #62

k-in opened this issue Sep 22, 2022 · 14 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@k-in
Copy link
Contributor

k-in commented Sep 22, 2022

[Bug]
In the defaul, the activeRevisionsMode of the revision is set to Single. However, when the GitHub action be executed, it is forced to change to Multiple.

image

[Solution]

  1. If revsion's activeRevisionsMode is Single, GitHub action exits with an error.
  2. As a warning, the above logic should be stated to the user.
    For me, I think No.1 is better.
@github-actions github-actions bot added the bug Something isn't working label Sep 22, 2022
@koudaiii
Copy link
Member

koudaiii commented Sep 26, 2022

I think this is the specification of aca-review-apps. 🤔 In that case, I think writing it in README as announcement information is enough. If you can think of anything that is a bug, please share it. 😄 I would like to discuss this issue with you. 😄

@horihiro horihiro added the documentation Improvements or additions to documentation label Sep 26, 2022
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Feb 28, 2023
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@PipeItToDevNull
Copy link

Are there any plans to support single revision mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants