Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting DNS name label as optional #54

Closed
wants to merge 4 commits into from
Closed

Conversation

kanika1894
Copy link
Contributor

@kanika1894 kanika1894 commented Jul 19, 2021

This is to fix #53
DNS Name label property is required only when IP address is public.

@kanika1894 kanika1894 marked this pull request as draft July 22, 2021 07:46
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This PR is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Aug 5, 2021
@kanika1894 kanika1894 closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting ip-address to Private causes an error
3 participants