- Adds initial templating support for build
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes a bug in `build` where `--pull` wasn't being set
ehotinger
requested review from
mnltejaswini,
northtyphoon and
sajayantony
as code owners
|
The formatting required to get a common date is a bit complex. |
Closed
|
@SteveLasker LGTM. #161 for first classing and simplifying it |
northtyphoon
reviewed
Jul 9, 2018
| @@ -139,7 +137,6 @@ func TestOverrideValuesWithBuildInfo(t *testing.T) { | |||
| // Base properties | |||
| {"{{.Build.ID}}", expectedID}, | |||
| {"{{.Build.Commit}}", expectedCommit}, | |||
| {"{{ .Build.Tag }}", expectedTag}, | |||
| {"{{ .Build.Repository}}", expectedRepo}, | |||
There was a problem hiding this comment.
[](start = 6, length = 1)
extra space
There was a problem hiding this comment.
@northtyphoon this one's on purpose, to make sure we can render it correctly with arbitrary white spaces on the side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR:
buildbuildwhere--pullwasn't being set{{.Build.Tag}}for now since it conflicts with--tagonbuild(and I'm not sure of its use case still)Fixes #139