Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class .Build.Date #162

Merged
merged 1 commit into from
Jul 9, 2018
Merged

First class .Build.Date #162

merged 1 commit into from
Jul 9, 2018

Conversation

ehotinger
Copy link
Contributor

@ehotinger ehotinger commented Jul 9, 2018

Purpose of the PR:

First classes {{.Build.Date}}, which defaults to time.Now().UTC() with yyyyMMdd-HHmmssz format.

Fixes #161

/cc @SteveLasker

@sajayantony
Copy link
Contributor

Once this is rolled out, I think we need to enable this format to be specified.

@ehotinger
Copy link
Contributor Author

ehotinger commented Jul 9, 2018

@sajayantony At that point you should just do {{ now | date "layout" }} which is already supported. I think it makes sense to first class a pre-defined date string so that people don't have to do that work, but once you start trimming/formatting/etc. you should be diving a bit deeper.

Copy link
Member

@northtyphoon northtyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ehotinger ehotinger merged commit 67f8f83 into Azure:master Jul 9, 2018
@ehotinger ehotinger deleted the ehotinger/date branch July 9, 2018 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants