Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Commit

Permalink
Kubernetes: --image-pull-progress-deadline 30m by default (#3199)
Browse files Browse the repository at this point in the history
  • Loading branch information
jackfrancis committed Jun 8, 2018
1 parent e7c9d23 commit 9374cd1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/clusterdefinition.md
Expand Up @@ -180,6 +180,7 @@ Below is a list of kubelet options that acs-engine will configure by default:
|"--non-masquerade-cidr"|"10.0.0.0/8"|
|"--azure-container-registry-config"|"/etc/kubernetes/azure.json"|
|"--pod-max-pids"|"100" (need to activate the feature in --feature-gates=SupportPodPidsLimit=true)|
|"--image-pull-progress-deadline"|"30m"|
|"--feature-gates"|No default (can be a comma-separated list). On agent nodes `Accelerators=true` will be applied in the `--feature-gates` option for k8s versions before 1.11.0|

Below is a list of kubelet options that are *not* currently user-configurable, either because a higher order configuration vector is available that enforces kubelet configuration, or because a static configuration is required to build a functional cluster:
Expand Down
1 change: 1 addition & 0 deletions pkg/acsengine/defaults-kubelet.go
Expand Up @@ -48,6 +48,7 @@ func setKubeletConfig(cs *api.ContainerService) {
"--event-qps": DefaultKubeletEventQPS,
"--cadvisor-port": DefaultKubeletCadvisorPort,
"--pod-max-pids": strconv.Itoa(DefaultKubeletPodMaxPIDs),
"--image-pull-progress-deadline": "30m",
}

// If no user-configurable kubelet config values exists, use the defaults
Expand Down
5 changes: 4 additions & 1 deletion pkg/acsengine/defaults-kubelet_test.go
Expand Up @@ -12,7 +12,10 @@ func TestKubeletConfigDefaults(t *testing.T) {
setKubeletConfig(cs)
k := cs.Properties.OrchestratorProfile.KubernetesConfig.KubeletConfig
// TODO test all default config values
for key, val := range map[string]string{"--azure-container-registry-config": "/etc/kubernetes/azure.json"} {
for key, val := range map[string]string{
"--azure-container-registry-config": "/etc/kubernetes/azure.json",
"--image-pull-progress-deadline": "30m",
} {
if k[key] != val {
t.Fatalf("got unexpected kubelet config value for %s: %s, expected %s",
key, k[key], val)
Expand Down

0 comments on commit 9374cd1

Please sign in to comment.