Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add support for k8s v1.9.1 #2006

Merged
merged 2 commits into from Jan 6, 2018
Merged

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jan 5, 2018

What this PR does / why we need it: adds Kubernetes v1.9.1 support

https://github.com/kubernetes/kubernetes/releases/tag/v1.9.1

Release note:

Add support for k8s v1.9.1

@ghost ghost assigned jackfrancis Jan 5, 2018
@ghost ghost added the in progress label Jan 5, 2018
}
]
}
},
"servicePrincipalProfile": {
"clientId": "",
"secret": ""
"clientID": "d65f68d4-7dc1-431e-a482-d3ba65f6f46e",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will probably need to deprecate this now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lolzing

@@ -2,11 +2,46 @@
"apiVersion": "vlabs",
"properties": {
"orchestratorProfile": {
"orchestratorType": "Kubernetes"
"orchestratorType": "Kubernetes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add these settings?

JiangtianLi
JiangtianLi previously approved these changes Jan 5, 2018
Copy link
Contributor

@JiangtianLi JiangtianLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

anhowe
anhowe previously approved these changes Jan 5, 2018
Copy link
Contributor

@anhowe anhowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit b7e5093 into Azure:master Jan 6, 2018
@jackfrancis jackfrancis deleted the k8s-v1.9.1 branch January 6, 2018 00:08
@ghost ghost removed the in progress label Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants