Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add the ability to use AAD groups #2037

Merged
merged 1 commit into from Jan 11, 2018
Merged

Conversation

mirthy
Copy link
Contributor

@mirthy mirthy commented Jan 11, 2018

What this PR does / why we need it: As per #1611, this adds the ability to use AAD groups and documents how to use it. The groups functionality is already built into AAD and it's just making sure it's turned on the Server Application AAD Manifest. Then, on the Kubernetes cluster side, it's just configuring the --oidc-groups-claim, which as no default, so it has to be set to groups for it read from AAD provided groups.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1611

Special notes for your reviewer:

  • This adds a parameter to to be included in the OIDC configuration, explicitly setting the groups claim --oidc-groups-claim to groups
  • Updated the documentation to include how to use groups and mention the steps that are required.

Release note:

Also added the groups OIDC claim
@msftclas
Copy link

msftclas commented Jan 11, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mirthy !

@jackfrancis jackfrancis merged commit f5be627 into Azure:master Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable AAD groups in RBAC
3 participants