chore(deps): upgrade go-autorest to v10.15.4 #3843
Conversation
ghost
assigned 
|
/lgtm pending e2e |
|
@weinong @jackfrancis @mboersma I see the possibility of some incongruity here as we are updating the go-autorest version and not the Azure Go SDK (which uses the go-autorest library heavily). What are your thoughts about updating the Azure Go SDK as well? |
| @@ -22,7 +22,7 @@ | |||
| version = "v19.0.0" | |||
There was a problem hiding this comment.
Let's upgrade to v20.1.0
There was a problem hiding this comment.
I'd like to do that as well--many services (including containerservices itself) have been updated in the SDK since v19.0.0. I think it would be safest to use the go-autorest version that was actually used to generate the Go SDK, if we can find that out.
There was a problem hiding this comment.
Apparently that was 10.15.3. Close enough.
There was a problem hiding this comment.
I checked with Martin Strobel earlier, the go sdk maintainer. He says using 10.15.4 of go-autorest along with v20.1.0 of go sdk should be fine.
There was a problem hiding this comment.
OTOH, upgrading sdk-for-go has a chance of breaking some API acs-engine is already using (and this has a cascade effect when vendored into AKS). If this is passing, maybe that should be a separate PR?
|
@tariq1890 @mboersma what's the // TODO at this point according to your recommendations? |
|
I guess the TODO would be to vendor in an Azure SDK Go release which contains the go-autorest referenced in this PR. From what I understand, go-autorest 10.15.4 is a bugfix release and that has not been vendored into Azure Go SDK as of yet. |
|
@tariq1890 can we do that as a follow-up? Or should we do it in this PR? |
|
We can do that in another PR. Hopefully, the next release of AzureGo SDK will have the deps set straight. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma, ultimateboy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updates the version of
go-autorestto the latest release, which includes several bug fixes.