Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

E2E: clusterFirst DNS liveness probe #4002

Closed
wants to merge 2 commits into from

Conversation

jackfrancis
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

E2E: clusterFirst DNS liveness probe

@acs-bot
Copy link

acs-bot commented Oct 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost ghost assigned jackfrancis Oct 12, 2018
@ghost ghost added in progress and removed approved labels Oct 12, 2018
@acs-bot acs-bot added the size/M label Oct 12, 2018
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #4002 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4002   +/-   ##
======================================
  Coverage    50.4%   50.4%           
======================================
  Files         109     109           
  Lines       16856   16856           
======================================
  Hits         8497    8497           
  Misses       7574    7574           
  Partials      785     785

@tariq1890
Copy link
Contributor

LGTM. Are we going to merge this?

@jackfrancis
Copy link
Member Author

I think it's unfinished. The problem reported was that ClusterFirst DNS + external resolvers was broken. So we want to add the external resolvers.

@CecileRobertMichon
Copy link
Contributor

@jackfrancis did this make it to https://github.com/Azure/aks-engine?

@ghost ghost removed the in progress label Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants