Fix validation for firstConsecutiveStaticIP

[ritazh]

What this PR does / why we need it: Fix validation for firstConsecutiveStaticIP

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

• documentation
• unit tests
• tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

[acs-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ritazh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

If they are not already assigned, you can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

I think this should go in the validate.go area, as this validation is only a convenience for acs-engine deploy CLI usage.

[ritazh]

This logic was originally in validate.go. But as we have seen in e2e tests, what we want to do here is to validate the user-provided apimodel, not the generated apimodel. Since we want to notify the user that we are generating this firstConsecutiveStaticIP for them if they are using custom vnet and VMSS master profile, instead of asking them to provide a value.

When we run e2e tests, cli_provisioner.go calls engine.ParseOutput in template.go which calls apiloader.LoadContainerServiceFromFile(path, true, false, nil) that triggers validate.goon the generated apimodel.

acs-engine/test/e2e/runner/cli_provisioner.go

Line 223 in 29ad616

csGenerated, err := engine.ParseOutput(engCfg.GeneratedDefinitionPath + "/apimodel.json")

This causes the e2e tests to fail since the generated apimodel now includes thefirstConsecutiveStaticIP we generated based on the vnetCidr provided by the user.

acs-engine/test/e2e/engine/template.go

Lines 283 to 294 in 29ad616

	// ParseOutput takes the generated api model and will parse that into a api.ContainerService
	func ParseOutput(path string) (*api.ContainerService, error) {
	locale, err := i18n.LoadTranslations()
	if err != nil {
	return nil, errors.Errorf(fmt.Sprintf("error loading translation files: %s", err.Error()))
	}
	apiloader := &api.Apiloader{
	Translator: &i18n.Translator{
	Locale: locale,
	},
	}
	containerService, _, err := apiloader.LoadContainerServiceFromFile(path, true, false, nil)

When we run acs-engine deploy, validateApimodel in deploy.go validates the user-provided apimodel before dc.containerService.SetPropertiesDefaults is called.

acs-engine/cmd/deploy.go

Lines 88 to 91 in 29ad616

	if _, _, err := dc.validateApimodel(); err != nil {
	log.Fatalf("Failed to validate the apimodel after populating values: %s", err.Error())
	}
	return dc.run()

[jackfrancis]

Hmm, vlabs/validate.go should only validate user input, not the generated data...

[CecileRobertMichon]

Closing since we've moved to https://github.com/Azure/aks-engine. @ritazh is this PR still relevant?

[ritazh]

@CecileRobertMichon I think this PR was created to address a failed e2e test. We can revisit this if the issue comes up again. Thanks!