This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 561
[WIP] Add NVIDIA drivers for k8s linux agents #989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanknox
suggested changes
Jul 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wbuchwalter. Need to hold on this until we answer some legal questions about automatically installing.
I updated this PR to allow for different drivers installation scripts depending on the |
jackfrancis
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @wbuchwalter and @lachie83
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically install NVIDIA drivers on linux agents for kubernetes.
Fixes #828
To Do:
Implementation Details:
By using the
*.run
file available on NVIDIA's website. This is the faster method, it takes ~2-3 minutes to install, but all the NVIDIA libraries are installed under/usr/lib/x86_64-linux-gnu/
, which means mounting the drivers into the container can be painful and create some conflicts. A workaround is to map/usr/lib/x86_64-linux-gnu/
to a different directory in the container, but it can probably still create some issues if you need to add both/usr/lib/x86_64-linux-gnu/
and the mounted path to yourLD_LIBRARY_PATH
. Here is an example of a template.By using
apt
with theppa
repository. Much slower to install, about ~12 minutes, so not ideal when scaling a lot, but the libraries are installed under a separate directory/usr/lib/nvidia-*
. This allows us to mount only the drivers into the container and nothing else, which should prevent any dependency/versioning issue. Here is an example of a template. This is the way I used in this PR. I assume most people using GPUs will run jobs that are quite long (in ML we are typically talking about hours) so 12 minutes shouldn't be a big deal, and this should cause less issues.This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)