Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: use the Azure CLI as an auth method #238

Merged
merged 1 commit into from Jan 11, 2019

Conversation

bacongobbler
Copy link
Contributor

Signed-off-by: Matthew Fisher matt.fisher@microsoft.com

Reason for Change: This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes. Marking this as a WIP as I haven't manually ran through with this; just experimenting with alternative auth methods.

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Jan 4, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bacongobbler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tariq1890

If they are not already assigned, you can assign the PR to them by writing /assign @tariq1890 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Makefile Outdated Show resolved Hide resolved
@bacongobbler bacongobbler force-pushed the cli-auth-method branch 2 times, most recently from e958767 to aca85df Compare January 7, 2019 19:49
@jackfrancis jackfrancis added this to In progress in backlog Jan 8, 2019
@bacongobbler bacongobbler changed the title (WIP) feat: use the Azure CLI as an auth method feat: use the Azure CLI as an auth method Jan 8, 2019
@bacongobbler
Copy link
Contributor Author

bacongobbler commented Jan 8, 2019

I've gone through and manually tested this so I believe it's ready for review (once I rebase this).

To test, run az login, then interact with aks-engine as usual. No service principal is required for authentication, but you'll still need to create one for the cluster itself:

$ az login
$ az group create -n $RG_NAME -l $LOCATION
$ az ad sp create-for-rbac --role="Contributor" --scopes="/subscriptions/$SUBID/resourceGroups/$RG_NAME"
$ aks-engine deploy --auth-method cli ...

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Jan 8, 2019

unit tests failed validate-dependencies

@bacongobbler
Copy link
Contributor Author

d'oh. Thanks for catching that. Will fix

@CecileRobertMichon
Copy link
Contributor

codecov is blocked because of our codecov breakage yesterday, if you rebase the PR it should run.

Is this ready for review?

@bacongobbler
Copy link
Contributor Author

yes! I will go and rebase this now. Thanks for the heads up.

This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@bacongobbler
Copy link
Contributor Author

to clarify: yes, this is ready for review.

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #238 into master will decrease coverage by 0.05%.
The diff coverage is 48.48%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   53.25%   53.19%   -0.06%     
==========================================
  Files          95       95              
  Lines       14246    14257      +11     
==========================================
- Hits         7586     7584       -2     
- Misses       5995     6008      +13     
  Partials      665      665

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bacongobbler bacongobbler merged commit 3b6b021 into Azure:master Jan 11, 2019
backlog automation moved this from In progress to Done Jan 11, 2019
@bacongobbler bacongobbler deleted the cli-auth-method branch January 11, 2019 17:33
jackfrancis pushed a commit that referenced this pull request Jan 11, 2019
This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants