-
Notifications
You must be signed in to change notification settings - Fork 522
feat: use the Azure CLI as an auth method #238
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bacongobbler If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e958767
to
aca85df
Compare
aca85df
to
e16143f
Compare
I've gone through and manually tested this so I believe it's ready for review (once I rebase this). To test, run
|
e16143f
to
0066708
Compare
unit tests failed |
d'oh. Thanks for catching that. Will fix |
0066708
to
594b4c3
Compare
codecov is blocked because of our codecov breakage yesterday, if you rebase the PR it should run. Is this ready for review? |
yes! I will go and rebase this now. Thanks for the heads up. |
This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
594b4c3
to
e8e95c5
Compare
to clarify: yes, this is ready for review. |
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 53.25% 53.19% -0.06%
==========================================
Files 95 95
Lines 14246 14257 +11
==========================================
- Hits 7586 7584 -2
- Misses 5995 6008 +13
Partials 665 665 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Signed-off-by: Matthew Fisher matt.fisher@microsoft.com
Reason for Change: This PR allows a user to authenticate using the Azure CLI 2.0 for development purposes. Marking this as a WIP as I haven't manually ran through with this; just experimenting with alternative auth methods.
Requirements:
Notes: