This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: update azure sdk to support BYOK #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyzhangx
force-pushed
the
byok-update-sdk-versio
branch
from
35e9fe2
to
da815a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2395 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 130 130
Lines 23341 23341
=======================================
Hits 16825 16825
Misses 5491 5491
Partials 1025 1025 |
|
@devigned could you do a sanity check review as well? |
|
lgtm++ |
devigned
suggested changes
Dec 5, 2019
fix mock test failure fix go.sum
andyzhangx
force-pushed
the
byok-update-sdk-versio
branch
from
da815a0
to
a8887c3
Compare
devigned
approved these changes
Dec 6, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, devigned, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
devigned
pushed a commit
to devigned/aks-engine
that referenced
this pull request
Dec 9, 2019
fix mock test failure fix go.sum
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
chore: update azure sdk to support BYOK
upgrade azure-sdk-for-go version from
v34.1.0tov36.2.0Issue Fixed:
Requirements:
Notes: