Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: check k8s events to see if node-problem-detector works #2444

Merged
merged 1 commit into from
Dec 14, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Dec 12, 2019

Reason for Change:
Adds an e2e test spec that creates a kernel message which node-problem-detector should turn into a Kubernetes event, if everything is wired up properly.

Issue Fixed:
Follows up on #2371
Refs #2389, #2411

Requirements:

Notes:

@mboersma
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #2444 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2444   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files         130      130           
  Lines       23606    23606           
=======================================
  Hits        17066    17066           
  Misses       5516     5516           
  Partials     1024     1024

@mboersma
Copy link
Member Author

I've tested this thoroughly with an apimodel that enables the node-problem-detector addon.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Dec 14, 2019
@acs-bot acs-bot merged commit 4a6a83d into Azure:master Dec 14, 2019
@acs-bot
Copy link

acs-bot commented Dec 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the npd-e2e branch January 24, 2020 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants