This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: node-problem-detector addon #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2371 +/- ##
==========================================
+ Coverage 72.08% 72.08% +<.01%
==========================================
Files 130 130
Lines 23310 23344 +34
==========================================
+ Hits 16803 16828 +25
- Misses 5482 5491 +9
Partials 1025 1025 |
juan-lee
reviewed
Nov 27, 2019
|
All looks good, but would be nice to get the metrics endpoint exposed. |
mboersma
force-pushed
the
node-problem-detector
branch
from
7a8ef21
to
74b2450
Compare
|
/lgtm I'll create an issue to make this add-on to default to enabled after we get more signal. |
devigned
approved these changes
Dec 3, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds the Kubernetes node problem detector as an addon.
Issue Fixed:
Fixes #2364
Requirements:
Notes:
Should this be enabled by default as suggested in #2364?