feat: Upgrade Azure Disk CSI driver to support various new features #2541
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2541 +/- ##
==========================================
- Coverage 72.15% 72.12% -0.03%
==========================================
Files 130 130
Lines 24486 24564 +78
==========================================
+ Hits 17668 17717 +49
- Misses 5797 5825 +28
- Partials 1021 1022 +1 |
/cc @andyzhangx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could remove 1.13 support, to reduce support burden since we use different deployment scripts between 1.13 and 1.14+, other part LGTM
Since we still support creating 1.13.11 clusters, if we remove Azure Disk CSI driver, |
@andyzhangx Should I also include kubernetes-sigs/azuredisk-csi-driver#252 into this PR? |
no, that PR is for next release. LGTM for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold |
Added cloud-controller-manager-enabled clusters as part of the e2e tests and ran on Jenkins against this PR - https://upstream.jenkins.azure-containers.io/view/aks-engine%20PRs/job/k8s-create-cluster-matrix/51/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, chewong, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
v1.0.1
->v1.4.0
v1.0.1
->v1.2.0
v0.3.0
->v0.5.0
v1.1.0
(>= k8s 1.13)v0.3.0
(>= k8s 1.16)volumeBindingMode: WaitForFirstConsumer
andallowedTopologies
key-value in storage class--feature-gates=Topology=true
in csi-provisionerallowVolumeExpansion: true
in storage class--feature-gates=VolumeSnapshotDataSource=true
in API server until >= k8s 1.17Issue Fixed:
Requirements:
Notes: