Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update go compiler to 1.14.2 #2839

Merged
merged 16 commits into from Apr 22, 2020
Merged

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Mar 4, 2020

Reason for Change:
Bumps the default compiler to go 1.14.2 and syncs golangci-lint with the local version.

See https://github.com/deis/docker-go-dev/releases/tag/v1.26.2

Issue Fixed:

Requirements:

Notes:
Previous versions of golangci-lint have caused problems in CI before, so let's watch for that.

@acs-bot
Copy link

acs-bot commented Mar 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma force-pushed the update-toolchain branch 2 times, most recently from 0723daa to 396cdaa Compare April 14, 2020 16:54
.golangci.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #2839 into master will not change coverage.
The diff coverage is 93.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2839   +/-   ##
=======================================
  Coverage   71.05%   71.05%           
=======================================
  Files         147      147           
  Lines       25671    25671           
=======================================
  Hits        18241    18241           
  Misses       6294     6294           
  Partials     1136     1136           
Impacted Files Coverage Δ
pkg/engine/engine.go 85.79% <83.33%> (ø)
pkg/engine/armvariables.go 86.08% <100.00%> (ø)
pkg/engine/transform/transform.go 72.52% <100.00%> (ø)
pkg/helpers/pki.go 89.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b54a2...0c05a4b. Read the comment docs.

@mboersma
Copy link
Member Author

I think I have finally gotten the current version of golangci-lint to behave, but given that the previous failures were a bit flaky (and that I can almost never reproduce it locally), let's give this a few more retries in CI.

@mboersma
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mboersma mboersma changed the title chore: update go-dev tools image chore: update go compiler to 1.14.2 Apr 22, 2020
@mboersma
Copy link
Member Author

Importantly, Go 1.14.2 (as well as 1.13.10) has a fix for the dreaded "PowerRegisterSuspendResumeNotification on Azure App Services" bug for which #2976 was intended as a temporary fix.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit c777d95 into Azure:master Apr 22, 2020
@mboersma mboersma deleted the update-toolchain branch April 22, 2020 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants