Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: typos in JSON annotations caught by staticcheck #3104

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:
Trying to fix #2839, I ran golangci-lint with the default linters enabled and couldn't ignore these typos. But I wonder if this could create actual backward-compatibility issues if the previous annotations weren't being honored as expected.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #3104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3104   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files         147      147           
  Lines       25472    25472           
=======================================
  Hits        18053    18053           
  Misses       6290     6290           
  Partials     1129     1129           
Impacted Files Coverage Δ
pkg/api/vlabs/types.go 73.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499b54b...1267750. Read the comment docs.

@jackfrancis
Copy link
Member

@mboersma I think this should be safe because the back-compat input scenario would include the JSON-rendered zero values already present. And those zero values should still be acceptable as aks-engine input.

@devigned @CecileRobertMichon for sanity check

@jackfrancis jackfrancis merged commit 6376694 into Azure:master Apr 21, 2020
@mboersma mboersma deleted the fix-json-annotations branch April 21, 2020 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants