feat: add support for Kubernetes 1.15.12 #3212
Conversation
/hold This has a temporary testing commit that should be discarded before merging. |
Codecov Report
@@ Coverage Diff @@
## master #3212 +/- ##
=======================================
Coverage 71.37% 71.37%
=======================================
Files 147 147
Lines 25687 25687
=======================================
Hits 18335 18335
Misses 6207 6207
Partials 1145 1145
Continue to review full report at Codecov.
|
This passed e2e tests for 1.15 here, so I'll discard the testing commit and this should be ready for review. |
/hold cancel |
FYI, I may have the |
@@ -85,13 +85,11 @@ function Get-FilesToCacheOnVHD | |||
"c:\akse-cache\win-k8s\" = @( | |||
"https://acs-mirror.azureedge.net/wink8s/azs-v1.14.7-1int.zip", | |||
"https://acs-mirror.azureedge.net/wink8s/azs-v1.14.8-1int.zip", | |||
"https://acs-mirror.azureedge.net/wink8s/azs-v1.15.7-1int.zip", | |||
"https://acs-mirror.azureedge.net/wink8s/azs-v1.15.9-1int.zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add https://kubernetesartifacts.azureedge.net/kubernetes/v1.15.12-azs/windowszip/v1.15.12-azs-1int.zip
and friends to the Windows VHD? That seems to be the current URL where this archive is published. cc: @jadarsie.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have a PR ready, just waiting for v1.15.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushing that PR as soon as I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do those changes in a separate PR just to keep it simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.15.md#changelog-since-v11511
Issue Fixed:
Requirements:
Notes: