Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.15.12 #3212

Merged
merged 2 commits into from May 11, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented May 6, 2020

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.15.md#changelog-since-v11511

Issue Fixed:

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@acs-bot acs-bot added the size/S label May 6, 2020
@mboersma
Copy link
Member Author

mboersma commented May 6, 2020

/hold

This has a temporary testing commit that should be discarded before merging.

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #3212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3212   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files         147      147           
  Lines       25687    25687           
=======================================
  Hits        18335    18335           
  Misses       6207     6207           
  Partials     1145     1145           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd276e...a20096c. Read the comment docs.

@mboersma
Copy link
Member Author

mboersma commented May 7, 2020

This passed e2e tests for 1.15 here, so I'll discard the testing commit and this should be ready for review.

@mboersma
Copy link
Member Author

mboersma commented May 7, 2020

/hold cancel

@jadarsie
Copy link
Member

jadarsie commented May 7, 2020

FYI, I may have the -azs image ready EOD

@acs-bot acs-bot added size/S and removed size/XS labels May 11, 2020
@mboersma mboersma added this to In progress in backlog via automation May 11, 2020
@@ -85,13 +85,11 @@ function Get-FilesToCacheOnVHD
"c:\akse-cache\win-k8s\" = @(
"https://acs-mirror.azureedge.net/wink8s/azs-v1.14.7-1int.zip",
"https://acs-mirror.azureedge.net/wink8s/azs-v1.14.8-1int.zip",
"https://acs-mirror.azureedge.net/wink8s/azs-v1.15.7-1int.zip",
"https://acs-mirror.azureedge.net/wink8s/azs-v1.15.9-1int.zip",
Copy link
Member Author

@mboersma mboersma May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add https://kubernetesartifacts.azureedge.net/kubernetes/v1.15.12-azs/windowszip/v1.15.12-azs-1int.zip and friends to the Windows VHD? That seems to be the current URL where this archive is published. cc: @jadarsie.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have a PR ready, just waiting for v1.15.10

Copy link
Member

@jadarsie jadarsie May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing that PR as soon as I can.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do those changes in a separate PR just to keep it simple.

backlog automation moved this from In progress to Review in progress May 11, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label May 11, 2020
@mboersma mboersma merged commit acd92e8 into Azure:master May 11, 2020
backlog automation moved this from Review in progress to Done May 11, 2020
@mboersma mboersma deleted the add-k8s-1.15.12 branch May 11, 2020 16:59
@acs-bot
Copy link

acs-bot commented May 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants