Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.19.0-rc.4 #3666

Merged
merged 2 commits into from Aug 7, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Aug 4, 2020

Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#changelog-since-v1190-rc3

Issue Fixed:

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:
The Azure k8s artifacts are still building, so this will fail at first.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #3666 into master will decrease coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3666      +/-   ##
==========================================
- Coverage   73.14%   73.14%   -0.01%     
==========================================
  Files         147      147              
  Lines       25165    25220      +55     
==========================================
+ Hits        18408    18448      +40     
- Misses       5623     5638      +15     
  Partials     1134     1134              
Impacted Files Coverage Δ
pkg/api/common/const.go 40.00% <ø> (ø)
pkg/api/common/versions.go 96.84% <ø> (ø)
pkg/engine/engine.go 85.64% <0.00%> (-0.31%) ⬇️
pkg/engine/templates_generated.go 53.26% <0.00%> (-0.36%) ⬇️
pkg/api/vlabs/validate.go 79.66% <87.50%> (+0.16%) ⬆️
pkg/api/addons.go 97.79% <100.00%> (+0.02%) ⬆️
pkg/api/k8s_versions.go 100.00% <100.00%> (ø)
pkg/engine/artifacts.go 99.14% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f321785...f0f4cc2. Read the comment docs.

@mboersma
Copy link
Member Author

mboersma commented Aug 5, 2020

Still working out a kind-related issue with the build pipeline, and then we will re-run CI once artifacts are published.

@mboersma
Copy link
Member Author

mboersma commented Aug 7, 2020

It looks like the AKS-Engine WS2019 VHD - docker job is taking just over two hours in this case (and 1:57 on some other PRs where it passed). So I added a commit that gives that job 2.5 hours. 🤞

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Aug 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit 0ca3854 into Azure:master Aug 7, 2020
@mboersma mboersma deleted the add-k8s-1.19.0-rc.4 branch August 7, 2020 21:01
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants