Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: upgrade metrics-server to v0.3.7 #3669

Merged
merged 9 commits into from Aug 14, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR updates the delivered version of metrics-server to v0.3.7 for all supported Kubernetes versions. See:

https://github.com/kubernetes-sigs/metrics-server/releases

Issue Fixed:

Requirements:

Notes:

@mboersma
Copy link
Member

mboersma commented Aug 5, 2020

Upgrade golang version to 1.12

Whoa slow down there metrics-server... 😆 (Go 1.15 is about to release.)

mboersma
mboersma previously approved these changes Aug 5, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #3669 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3669      +/-   ##
==========================================
+ Coverage   73.10%   73.15%   +0.05%     
==========================================
  Files         147      147              
  Lines       25257    25301      +44     
==========================================
+ Hits        18463    18508      +45     
+ Misses       5657     5655       -2     
- Partials     1137     1138       +1     
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/api/vlabs/types.go 71.83% <0.00%> (ø)
pkg/engine/template_generator.go 82.05% <0.00%> (+0.02%) ⬆️
pkg/api/types.go 94.31% <0.00%> (+0.06%) ⬆️
pkg/api/converterfromapi.go 94.17% <0.00%> (+0.07%) ⬆️
pkg/api/convertertoapi.go 93.68% <0.00%> (+0.07%) ⬆️
pkg/engine/templates_generated.go 53.42% <0.00%> (+0.15%) ⬆️
pkg/api/vlabs/validate.go 80.00% <0.00%> (+0.33%) ⬆️
pkg/engine/params.go 67.85% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495dc66...df48a0a. Read the comment docs.

@jackfrancis
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis jackfrancis added this to Review in progress in backlog Aug 6, 2020
mboersma
mboersma previously approved these changes Aug 7, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis
Copy link
Member Author

Initial test signal suggests that 1.15 doesn't work with (this) metrics-server v0.3 spec. So maybe we need to undo that change. Stay tuned.

@jackfrancis
Copy link
Member Author

/hold

@jackfrancis
Copy link
Member Author

/hold release

pkg/api/k8s_versions.go Outdated Show resolved Hide resolved
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Aug 13, 2020
@acs-bot
Copy link

acs-bot commented Aug 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 6f964c0 into Azure:master Aug 14, 2020
backlog automation moved this from Review in progress to Done Aug 14, 2020
@jackfrancis jackfrancis deleted the metrics-server-v0.3.7 branch August 14, 2020 00:11
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants