-
Notifications
You must be signed in to change notification settings - Fork 525
chore: upgrade metrics-server to v0.3.7 #3669
Conversation
Whoa slow down there metrics-server... 😆 (Go 1.15 is about to release.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #3669 +/- ##
==========================================
+ Coverage 73.10% 73.15% +0.05%
==========================================
Files 147 147
Lines 25257 25301 +44
==========================================
+ Hits 18463 18508 +45
+ Misses 5657 5655 -2
- Partials 1137 1138 +1
Continue to review full report at Codecov.
|
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Initial test signal suggests that 1.15 doesn't work with (this) metrics-server v0.3 spec. So maybe we need to undo that change. Stay tuned. |
/hold |
/hold release |
3b94e0f
to
e7f80cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
This PR updates the delivered version of metrics-server to v0.3.7 for all supported Kubernetes versions. See:
https://github.com/kubernetes-sigs/metrics-server/releases
Issue Fixed:
Requirements:
Notes: