Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update Windows VHD to include 8B patches #3692

Merged
merged 2 commits into from Aug 13, 2020
Merged

chore: update Windows VHD to include 8B patches #3692

merged 2 commits into from Aug 13, 2020

Conversation

mainred
Copy link
Member

@mainred mainred commented Aug 12, 2020

Reason for Change:

August 11 patches for windows are released

https://support.microsoft.com/en-us/help/4565349

Requirements:

Notes:

AbelHu
AbelHu previously approved these changes Aug 12, 2020
@mboersma mboersma changed the title chore: udpating Windows VHD to include 8B patches chore: update Windows VHD to include 8B patches Aug 12, 2020
@jsturtevant
Copy link
Contributor

jsturtevant commented Aug 12, 2020

The base image the VHD is based on, also needs to be updated:

"image_version": "17763.1282.2006061952",

should be updated to 17763.1339.2007101755

az vm image show --urn MicrosoftWindowsServer:WindowsServer:2019-Datacenter-Core-with-Containers-smalldisk:latest
{
  "automaticOsUpgradeProperties": {
    "automaticOsUpgradeSupported": false
  },
  "dataDiskImages": [],
  "hyperVgeneration": "V1",
  "id": "/Subscriptions/b9d9436a-0c07-4fe8-b779-2c1030bd7997/Providers/Microsoft.Compute/Locations/westus/Publishers/MicrosoftWindowsServer/ArtifactTypes/VMImage/Offers/WindowsServer/Skus/2019-Datacenter-Core-with-Containers-smalldisk/Versions/17763.1339.2007101755",
  "location": "westus",
  "name": "17763.1339.2007101755",
  "osDiskImage": {
    "operatingSystem": "Windows",
    "sizeInBytes": 32214352384,
    "sizeInGb": 31
  },
  "plan": null,
  "tags": null
}

@mainred
Copy link
Member Author

mainred commented Aug 13, 2020

@jsturtevant . Thanks for your comment.
To understand the base image change, I think it's because a windows patch contains changes based on the last month's base image, cc @AbelHu

@jsturtevant
Copy link
Contributor

/lgtm

@jsturtevant
Copy link
Contributor

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@acs-bot
Copy link

acs-bot commented Aug 13, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AbelHu, jsturtevant, mainred
To complete the pull request process, please assign mboersma
You can assign the PR to them by writing /assign @mboersma in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #3692 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
- Coverage   73.14%   73.10%   -0.05%     
==========================================
  Files         147      147              
  Lines       25220    25257      +37     
==========================================
+ Hits        18448    18463      +15     
- Misses       5638     5657      +19     
- Partials     1134     1137       +3     
Impacted Files Coverage Δ
pkg/armhelpers/mockclients.go 21.84% <0.00%> (-0.34%) ⬇️
pkg/armhelpers/kubeclient.go 0.00% <0.00%> (ø)
pkg/armhelpers/azurestack/kubeclient.go 0.00% <0.00%> (ø)
pkg/operations/kubernetesupgrade/upgrader.go 63.55% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c273c51...9dd1c32. Read the comment docs.

@jsturtevant jsturtevant merged commit dedcef0 into Azure:master Aug 13, 2020
@mainred mainred deleted the win-vhd-2019-8b-patch branch September 8, 2020 08:13
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
* chore: udpating Windows VHD to include 8B patches
* Update base image
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants