Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update csi-secrets-store to v0.0.19 and akv provider to 0.0.12 #4203

Merged
merged 1 commit into from Jan 27, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 27, 2021

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@aramase
Copy link
Member Author

aramase commented Jan 27, 2021

@andyzhangx What is the plan to update azuredisk-csi and azurefile-csi to use the latest liveness-probe releases? There was a memory leak issue fixed in the recent releases and we have updated to using that upstream in secrets-store-csi-driver. I would like to bump the version in aks-engine once other csi components pick up the latest.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #4203 (1193328) into master (e9b1f90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4203   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files         135      135           
  Lines       20849    20849           
=======================================
  Hits        15308    15308           
  Misses       4566     4566           
  Partials      975      975           
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)
pkg/engine/templates_generated.go 44.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b1f90...1193328. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 2b6999b into Azure:master Jan 27, 2021
@aramase aramase deleted the update-csi-images-v0.0.19 branch January 27, 2021 21:20
@andyzhangx
Copy link
Contributor

@andyzhangx What is the plan to update azuredisk-csi and azurefile-csi to use the latest liveness-probe releases? There was a memory leak issue fixed in the recent releases and we have updated to using that upstream in secrets-store-csi-driver. I would like to bump the version in aks-engine once other csi components pick up the latest.

@aramase thanks, we already use mcr.microsoft.com/oss/kubernetes-csi/livenessprobe:v2.2.0 on master branch, will publish a new release soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants