feat: add support for Kubernetes v1.18.16 #4284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4284 +/- ##
==========================================
+ Coverage 72.02% 72.03% +0.01%
==========================================
Files 141 141
Lines 21625 21633 +8
==========================================
+ Hits 15576 15584 +8
Misses 5099 5099
Partials 950 950
Continue to review full report at Codecov.
|
jackfrancis
force-pushed
the
add-k8s-1.18.16
branch
from
14482e6
to
e2ea29b
Compare
| @@ -61,7 +61,7 @@ var _ = Describe("Upgrade Kubernetes cluster tests", func() { | |||
| }) | |||
|
|
|||
| It("Should succeed when cluster VMs are missing expected tags during upgrade operation", func() { | |||
| cs := api.CreateMockContainerService("testcluster", "1.18.15", 1, 1, false) | |||
| cs := api.CreateMockContainerService("testcluster", "", 1, 1, false) | |||
There was a problem hiding this comment.
100% of UT should not care about our maintaining the versions support list, so shout if this ever bites you in the future!
cc @mboersma
| mockClient.MakeFakeVirtualMachineScaleSetVM("Kubernetes:1.18.10"), | ||
| mockClient.MakeFakeVirtualMachineScaleSetVM("Kubernetes:1.18.9"), | ||
| mockClient.MakeFakeVirtualMachineScaleSetVM("Kubernetes:1.18.15"), | ||
| mockClient.MakeFakeVirtualMachineScaleSetVM("Kubernetes:1.16.15"), |
There was a problem hiding this comment.
just to prevent any unnecessary search/replace queries from coming up in the past, setting these UT data to a permanently deprecated version (the UT are just testing for version equality, they don't care about the supported versions list)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v11815
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes:
This will fail a unit test because Azure Stack expects 1.18.15 support. I'm not sure how to handle this. cc: @jadarsie