ci: Fix flaky docker rotate e2e test #4353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4353 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 141 141
Lines 21640 21640
=======================================
Hits 15596 15596
Misses 5093 5093
Partials 951 951 Continue to review full report at Codecov.
|
| @@ -2435,6 +2435,10 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu | |||
| Skip("No windows agent was provisioned for this Cluster Definition") | |||
| } | |||
|
|
|||
| if !eng.ExpandedDefinition.Properties.OrchestratorProfile.KubernetesConfig.RequiresDocker() { | |||
| Skip("Skip docker validations on non-docker-backed clusters") | |||
There was a problem hiding this comment.
CRI log rotate went stable in v1.21
kubernetes/enhancements#2411
Should we create an issue to investigate added a test for that with aks-engine?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jsturtevant, marosset, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
The test was checking the date which wasn't in the last 20 lines because the log output is too verbose. This checks further back in the output to ensure we always have a date stamp
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: