Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: make Azure Disk & File CSI drivers work on 1.22 #4638

Merged
merged 1 commit into from Sep 9, 2021

Conversation

andyzhangx
Copy link
Contributor

@andyzhangx andyzhangx commented Sep 6, 2021

Reason for Change:

fix: make Azure Disk & File CSI drivers work on 1.22

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@andyzhangx
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@andyzhangx

This comment has been minimized.

@andyzhangx
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@andyzhangx
Copy link
Contributor Author

@jackfrancis @chewong could you help review? Thanks.

Copy link

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI didn't install azuredisk-csi-driver as part of their e2e run. Have you tried creating a 1.22 test cluster?

@andyzhangx
Copy link
Contributor Author

Looks like the CI didn't install azuredisk-csi-driver as part of their e2e run. Have you tried creating a 1.22 test cluster?

@chewong yes, I have tested on 1.22 cluster on both Linux and Windows node pools.

@andyzhangx
Copy link
Contributor Author

/assign @jackfrancis

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andyzhangx
Copy link
Contributor Author

can someone merge this PR? thanks.

@jackfrancis jackfrancis merged commit 46aece6 into Azure:master Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants