This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: make Azure Disk & File CSI drivers work on 1.22 #4638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
andyzhangx
force-pushed
the
csi-drvers-1.22-fix
branch
from
September 6, 2021 01:59
b1e3a1f
to
9707e71
Compare
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
@jackfrancis @chewong could you help review? Thanks. |
chewong
reviewed
Sep 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI didn't install azuredisk-csi-driver as part of their e2e run. Have you tried creating a 1.22 test cluster?
@chewong yes, I have tested on 1.22 cluster on both Linux and Windows node pools. |
/assign @jackfrancis |
jackfrancis
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
chewong
approved these changes
Sep 8, 2021
can someone merge this PR? thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
fix: make Azure Disk & File CSI drivers work on 1.22
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: