Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: install -proposed systemd package #630

Merged
merged 3 commits into from Mar 5, 2019

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Mar 2, 2019

Reason for Change:

Use the -proposed systemd xenial package to get needed required systemd patch to address the following:

kubernetes/kubernetes#57345

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #630 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   63.82%   63.84%   +0.02%     
==========================================
  Files          91       91              
  Lines       13947    14035      +88     
==========================================
+ Hits         8901     8961      +60     
- Misses       4375     4396      +21     
- Partials      671      678       +7

@jackfrancis jackfrancis added this to In progress in backlog Mar 4, 2019
@@ -107,6 +107,14 @@ write_files:
RemainAfterExit=yes
ExecStart=/usr/local/bin/health-monitor.sh container-runtime

- path: /etc/apt/preferences.d/proposed-updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a Bionic equivalent for 18.04? Just curious on how I can integrate this with the 18.04 PR

@jackfrancis jackfrancis changed the title [WIP] chore: install -proposed systemd package chore: install -proposed systemd package Mar 4, 2019
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Mar 5, 2019
@acs-bot acs-bot merged commit 4064a43 into Azure:master Mar 5, 2019
backlog automation moved this from In progress to Done Mar 5, 2019
@acs-bot
Copy link

acs-bot commented Mar 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tariq1890 pushed a commit to tariq1890/aks-engine that referenced this pull request Mar 5, 2019
@tariq1890 tariq1890 moved this from TODO to Done in Go template refactor Mar 11, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
* chore: install -proposed systemd package

* chore: use standard apt_get_install func

* chore: add systemd install message
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants