feat: add support for Ubuntu 18.04-LTS #223

CecileRobertMichon · 2019-01-03T19:31:30Z

Reason for Change:

Add support for Ubuntu 18.04-LTS. This includes a new VHD that is based on top of 18.04. The default is still 16.04-LTS so this will have to be specified explicitly for now. Upgrades and scale operations are unaffected.

Issue Fixed:

Fixes #222

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

codecov · 2019-01-04T02:25:15Z

Codecov Report

Merging #223 into master will increase coverage by 0.58%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   67.91%   68.49%   +0.58%     
==========================================
  Files         115      115              
  Lines       16856    16896      +40     
==========================================
+ Hits        11447    11573     +126     
+ Misses       4614     4521      -93     
- Partials      795      802       +7

pkg/api/const.go

CecileRobertMichon · 2019-01-09T21:36:15Z

/hold

CecileRobertMichon · 2019-01-09T21:46:26Z

pkg/api/const.go

@@ -26,10 +26,12 @@ const (
 // the LinuxDistros supported by vlabs
 const (
 	Ubuntu          Distro = "ubuntu"
+	Ubuntu1804      Distro = "ubuntu-18.04"


default distro doesn't change, we are simply adding a two new distro options for new deployments. Upgrades and scale operations are unaffected.

CecileRobertMichon · 2019-01-14T04:33:07Z

moby/libnetwork#2187

moby/moby#37485

CecileRobertMichon · 2019-03-14T16:19:30Z

/azp run pr-e2e

azure-pipelines · 2019-03-14T16:19:46Z

Azure Pipelines successfully started running 1 pipeline(s).

CecileRobertMichon · 2019-03-15T17:55:21Z

/hold cancel

CecileRobertMichon · 2019-03-15T17:55:39Z

/azp run pr-e2e

azure-pipelines · 2019-03-15T17:55:53Z

Azure Pipelines successfully started running 1 pipeline(s).

CecileRobertMichon · 2019-03-15T17:56:34Z

parts/k8s/kubernetesinstalls.sh

@@ -316,3 +317,13 @@ cleanUpContainerImages() {
        docker rmi $(docker images --format '{{.Repository}}:{{.Tag}}' | grep 'nginx') &
    fi
 }
+
+overrideNetworkConfig() {


this is the workaround suggested by the az linux team to workaround #761

We don't want to do this via cloud-init?

because there is a cloud init bug that is preventing this from being user overridable. @jasonzio from AzLinux has a PR to fix it open but it might take a while before it gets in. See the email thread for more context.

thanks for the context!

bump vhd version for moby 3.0.3 disable apply_network_config Test to see if this improves OSPTO issues add extra indent re-add line return remove brackets add brackets skip proposed-updates file for 18.04 fix distro type add resolv-conf to kubelet config for testing add missing "then" in bash script remove datasource fix attempt distro specific kubelet flag and unit tests pass in nil value for agent profile for masters fix unit tests Fix isUbuntu1604 method to account for windows fix typo orchestratorProfile should be MasterProfile add isUbuntu1804 function fix function call fix unit tests update VHD version change to !Windows to account for empty osType revert skip adding "--resolv-conf" case in windows static kubelet config switch remove xenial-proposed logic

jackfrancis · 2019-03-16T06:28:08Z

@CecileRobertMichon FYI rebased / force-pushed

jackfrancis · 2019-03-16T06:28:14Z

/azp run pr-e2e

azure-pipelines · 2019-03-16T06:28:25Z

Azure Pipelines successfully started running 1 pipeline(s).

packer/install-dependencies.sh

mboersma · 2019-03-19T17:05:06Z

lgtm

serbrech

lgtm

docs/topics/clusterdefinitions.md

pkg/api/defaults-kubelet.go

Co-Authored-By: CecileRobertMichon <cerobert@microsoft.com>

CecileRobertMichon · 2019-03-19T17:36:34Z

/azp run pr-e2e

azure-pipelines · 2019-03-19T17:36:57Z

Azure Pipelines successfully started running 1 pipeline(s).

jackfrancis · 2019-03-19T21:13:11Z

/lgtm

acs-bot · 2019-03-19T21:14:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

acs-bot added the size/M label Jan 3, 2019

CecileRobertMichon changed the title ~~feat: add support for Ubuntu 18.04~~ [WIP] feat: add support for Ubuntu 18.04 Jan 3, 2019

acs-bot added do-not-merge/work-in-progress approved labels Jan 3, 2019

jackfrancis reviewed Jan 4, 2019

View reviewed changes

pkg/api/const.go Outdated Show resolved Hide resolved

jackfrancis added this to In progress in backlog Jan 4, 2019

CecileRobertMichon mentioned this pull request Jan 7, 2019

[WIP] Ubuntu 18.04 Azure/acs-engine#4251

Closed

3 tasks

acs-bot added size/L and removed size/M labels Jan 7, 2019

CecileRobertMichon force-pushed the ubuntu-1804 branch from 4ed8b48 to d4a0b5b Compare January 7, 2019 19:48

acs-bot added size/M size/L and removed size/L size/M labels Jan 7, 2019

paulgmiller mentioned this pull request Jan 7, 2019

Increase user watches on nodes Azure/AKS#772

Closed

CecileRobertMichon force-pushed the ubuntu-1804 branch from 5318780 to 9e5ae3a Compare January 9, 2019 21:31

CecileRobertMichon changed the title ~~[WIP] feat: add support for Ubuntu 18.04~~ feat: add support for Ubuntu 18.04 Jan 9, 2019

acs-bot removed the do-not-merge/work-in-progress label Jan 9, 2019

acs-bot added the do-not-merge/hold label Jan 9, 2019

This comment has been minimized.

Sign in to view

CecileRobertMichon commented Jan 9, 2019

View reviewed changes

CecileRobertMichon force-pushed the ubuntu-1804 branch from 9e5ae3a to be9df1e Compare January 9, 2019 22:53

CecileRobertMichon changed the title ~~feat: add support for Ubuntu 18.04~~ feat: add support for Ubuntu 18.04-LTS Jan 9, 2019

This comment has been minimized.

Sign in to view

CecileRobertMichon force-pushed the ubuntu-1804 branch from be9df1e to 364ce31 Compare January 14, 2019 03:39

This comment has been minimized.

Sign in to view

CecileRobertMichon force-pushed the ubuntu-1804 branch from f116441 to a48682b Compare March 15, 2019 17:48

acs-bot removed the do-not-merge/hold label Mar 15, 2019

CecileRobertMichon commented Mar 15, 2019

View reviewed changes

Cecile Robert-Michon added 3 commits March 15, 2019 23:27

chore: add VHD release notes

7bd87eb

fix: add network_config override

858776d

jackfrancis force-pushed the ubuntu-1804 branch from a48682b to 858776d Compare March 16, 2019 06:27

tariq1890 reviewed Mar 19, 2019

View reviewed changes

packer/install-dependencies.sh Outdated Show resolved Hide resolved

serbrech approved these changes Mar 19, 2019

View reviewed changes

docs/topics/clusterdefinitions.md Outdated Show resolved Hide resolved

pkg/api/defaults-kubelet.go Outdated Show resolved Hide resolved

tariq1890 and others added 2 commits March 19, 2019 10:28

Update packer/install-dependencies.sh with suggestion

252df82

Co-Authored-By: CecileRobertMichon <cerobert@microsoft.com>

apply review comments

b1356c5

acs-bot assigned jackfrancis Mar 19, 2019

acs-bot added the lgtm label Mar 19, 2019

CecileRobertMichon merged commit 90b996a into Azure:master Mar 19, 2019

backlog automation moved this from In progress to Done Mar 19, 2019

CecileRobertMichon deleted the ubuntu-1804 branch April 18, 2019 22:43

nawazkh mentioned this pull request Mar 8, 2023

add /etc/cloud/cloud.cfg.d/15_azure-vnet.cfg to all Azure VMs kubernetes-sigs/image-builder#1090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for Ubuntu 18.04-LTS #223

feat: add support for Ubuntu 18.04-LTS #223

CecileRobertMichon commented Jan 3, 2019 •

edited

Loading

codecov bot commented Jan 4, 2019 •

edited

Loading

CecileRobertMichon commented Jan 9, 2019

This comment has been minimized.

CecileRobertMichon Jan 9, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

CecileRobertMichon commented Jan 14, 2019

CecileRobertMichon commented Mar 14, 2019

azure-pipelines bot commented Mar 14, 2019

CecileRobertMichon commented Mar 15, 2019

CecileRobertMichon commented Mar 15, 2019

azure-pipelines bot commented Mar 15, 2019

CecileRobertMichon Mar 15, 2019

jackfrancis Mar 19, 2019

CecileRobertMichon Mar 19, 2019

jackfrancis Mar 19, 2019

jackfrancis commented Mar 16, 2019

jackfrancis commented Mar 16, 2019

azure-pipelines bot commented Mar 16, 2019

mboersma commented Mar 19, 2019

serbrech left a comment

CecileRobertMichon commented Mar 19, 2019

azure-pipelines bot commented Mar 19, 2019

jackfrancis commented Mar 19, 2019

acs-bot commented Mar 19, 2019

feat: add support for Ubuntu 18.04-LTS #223

feat: add support for Ubuntu 18.04-LTS #223

Conversation

CecileRobertMichon commented Jan 3, 2019 • edited Loading

codecov bot commented Jan 4, 2019 • edited Loading

Codecov Report

CecileRobertMichon commented Jan 9, 2019

This comment has been minimized.

CecileRobertMichon Jan 9, 2019

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

CecileRobertMichon commented Jan 14, 2019

CecileRobertMichon commented Mar 14, 2019

azure-pipelines bot commented Mar 14, 2019

CecileRobertMichon commented Mar 15, 2019

CecileRobertMichon commented Mar 15, 2019

azure-pipelines bot commented Mar 15, 2019

CecileRobertMichon Mar 15, 2019

Choose a reason for hiding this comment

jackfrancis Mar 19, 2019

Choose a reason for hiding this comment

CecileRobertMichon Mar 19, 2019

Choose a reason for hiding this comment

jackfrancis Mar 19, 2019

Choose a reason for hiding this comment

jackfrancis commented Mar 16, 2019

jackfrancis commented Mar 16, 2019

azure-pipelines bot commented Mar 16, 2019

mboersma commented Mar 19, 2019

serbrech left a comment

Choose a reason for hiding this comment

CecileRobertMichon commented Mar 19, 2019

azure-pipelines bot commented Mar 19, 2019

jackfrancis commented Mar 19, 2019

acs-bot commented Mar 19, 2019

CecileRobertMichon commented Jan 3, 2019 •

edited

Loading

codecov bot commented Jan 4, 2019 •

edited

Loading