Conversation
image isn't live yet /hold |
@@ -0,0 +1,113 @@ | |||
Starting build on Tue Mar 5 17:41:16 UTC 2019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a bit more work for making the notes formatting a bit nicer + automatically creating the pull request but this is iteration 1 :)
- mount | ||
- nfs-common | ||
- pigz socat | ||
- systemd/xenial-proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- mount | ||
- nfs-common | ||
- pigz socat | ||
- systemd/xenial-proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel |
Does this close #648? |
@mboersma no |
/azp run pr-e2e |
No pipelines are associated with this pull request. |
@@ -0,0 +1,114 @@ | |||
Starting build on Tue Mar 5 17:41:16 UTC 2019 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get rid of the colon
in the filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underscore instead? I used the name as it appears in az vm image list
but it's true that colon isn't great in a filename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underscore/hyphen/period, I think anything is better than colon (or any slash character)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went for underscore
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 91 91
Lines 14022 14022
=======================================
Hits 8960 8960
Misses 4385 4385
Partials 677 677 |
Rebased this PR as it derived from master before #634 landed. (and whew, that was alarming) |
/azp run pr-e2e |
No pipelines are associated with this pull request. |
Validated that this GPU restores N series + GPU cluster scenarios. |
FYI @mboersma @jackfrancis (I don't know who added it) this doesn't fix #647 it only mitigates it (the bug will still be there next time we change the version, so removing it from description. |
whoops sorry about that, I need to rebase my fork master |
@CecileRobertMichon Good point. I guess we don't have an issue for the current predicament "GPU scenario broken in master". |
/azp run pr-e2e |
No pipelines are associated with this pull request. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Includes new GPU driver version and new systemd proposed version.
Issue Fixed:
Mitigates #647
Fixes #661
Requirements:
Notes: