Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update VHD to 2019.03.05 #654

Merged
merged 5 commits into from Mar 6, 2019

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Mar 5, 2019

Reason for Change:

Includes new GPU driver version and new systemd proposed version.

Issue Fixed:

Mitigates #647
Fixes #661

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Mar 6, 2019
@CecileRobertMichon
Copy link
Contributor Author

image isn't live yet

/hold

@@ -0,0 +1,113 @@
Starting build on Tue Mar 5 17:41:16 UTC 2019
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a bit more work for making the notes formatting a bit nicer + automatically creating the pull request but this is iteration 1 :)

- mount
- nfs-common
- pigz socat
- systemd/xenial-proposed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- mount
- nfs-common
- pigz socat
- systemd/xenial-proposed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mboersma
Copy link
Member

mboersma commented Mar 6, 2019

/hold cancel

@mboersma mboersma added this to In progress in backlog Mar 6, 2019
@mboersma
Copy link
Member

mboersma commented Mar 6, 2019

Does this close #648?

@jackfrancis
Copy link
Member

@mboersma no

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@@ -0,0 +1,114 @@
Starting build on Tue Mar 5 17:41:16 UTC 2019
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get rid of the colon in the filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscore instead? I used the name as it appears in az vm image list but it's true that colon isn't great in a filename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscore/hyphen/period, I think anything is better than colon (or any slash character)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went for underscore

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #654 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files          91       91           
  Lines       14022    14022           
=======================================
  Hits         8960     8960           
  Misses       4385     4385           
  Partials      677      677

@jackfrancis
Copy link
Member

Rebased this PR as it derived from master before #634 landed. (and whew, that was alarming)

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jackfrancis
Copy link
Member

Validated that this GPU restores N series + GPU cluster scenarios.

@CecileRobertMichon
Copy link
Contributor Author

FYI @mboersma @jackfrancis (I don't know who added it) this doesn't fix #647 it only mitigates it (the bug will still be there next time we change the version, so removing it from description.

@CecileRobertMichon
Copy link
Contributor Author

Rebased this PR as it derived from master before #634 landed. (and whew, that was alarming)

whoops sorry about that, I need to rebase my fork master

@jackfrancis
Copy link
Member

@CecileRobertMichon Good point. I guess we don't have an issue for the current predicament "GPU scenario broken in master".

@CecileRobertMichon
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 2e05c88 into Azure:master Mar 6, 2019
backlog automation moved this from In progress to Done Mar 6, 2019
danmassie pushed a commit to danmassie/aks-engine that referenced this pull request Mar 9, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
@CecileRobertMichon CecileRobertMichon deleted the new-vhd-3 branch April 18, 2019 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

high "loaded inactive dead" systemd mount units
4 participants