This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: pre-pull Azure Stack's custom Hyperkube #1040
feat: pre-pull Azure Stack's custom Hyperkube #1040
Changes from 12 commits
cf2a8c4
2d169db
fad7228
9589577
4867cd4
ef89dfe
e6dd2e9
9ecf58b
2780d65
9358809
b27553f
7ce621d
8397555
329babe
822d74f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of this should be outside of the if block, right? The only conditional change is to
HYPERKUBE_URL
, correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the hyperkube image is different, cloud-controller-manager remains the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point is, this implementation doesn't actually pre-pull the image in the Azure Stack case. The if should be:
Unless I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function
extractHyperkube
callspullContainerImage $CLI_TOOL ${HYPERKUBE_URL}
.That clears your concern, right?