Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Add toggle for switching ip-masq-agent logic for AKS. #129

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

JunSun17
Copy link
Contributor

Add toggle for switching ip-masq-agent logic for AKS. This way, the AKS-engine code can be checked in first. Later when AKS turn on the toggle, it should activate this feature.

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #129 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   53.12%   53.14%   +0.01%     
==========================================
  Files          95       95              
  Lines       14183    14188       +5     
==========================================
+ Hits         7535     7540       +5     
  Misses       5977     5977              
  Partials      671      671

1 similar comment
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #129 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   53.12%   53.14%   +0.01%     
==========================================
  Files          95       95              
  Lines       14183    14188       +5     
==========================================
+ Hits         7535     7540       +5     
  Misses       5977     5977              
  Partials      671      671

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #129 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   53.12%   53.15%   +0.03%     
==========================================
  Files          95       95              
  Lines       14183    14188       +5     
==========================================
+ Hits         7535     7542       +7     
+ Misses       5977     5976       -1     
+ Partials      671      670       -1

@acs-bot acs-bot added size/M and removed size/S labels Dec 11, 2018
@tariq1890
Copy link
Contributor

@JunSun17 I believe we can do this in a different way. Since ipMasqAgent is an addon, we can always disable that addon via the apimodel using the existing fields

@JunSun17
Copy link
Contributor Author

JunSun17 commented Dec 12, 2018

@JunSun17 I believe we can do this in a different way. Since ipMasqAgent is an addon, we can always disable that addon via the apimodel using the existing fields

@tariq1890 I do not quite understand, can you elaborate what field you are proposing to disable the addon. Please also note, the IP-MASQ-AGENT for aks engine has already been done by @jackfrancis . However, AKS is handling addon differently, and this PR mainly adds a toggle for AKS to turn on/off this feature.

@tariq1890
Copy link
Contributor

/lgtm

@tariq1890
Copy link
Contributor

@JunSun17 Makes sense. Thanks for the clarification :)

@acs-bot
Copy link

acs-bot commented Dec 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JunSun17, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890 tariq1890 merged commit 4ace5af into Azure:master Dec 18, 2018
tariq1890 added a commit that referenced this pull request Dec 18, 2018
@tariq1890 tariq1890 mentioned this pull request Dec 18, 2018
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
* Add toggle for switching ip-masq-agent logic for AKS.

* Add unit tests.
@JunSun17 JunSun17 deleted the jusu-ip-masq-agent branch April 16, 2019 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants