-
Notifications
You must be signed in to change notification settings - Fork 527
Add toggle for switching ip-masq-agent logic for AKS. #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 53.12% 53.14% +0.01%
==========================================
Files 95 95
Lines 14183 14188 +5
==========================================
+ Hits 7535 7540 +5
Misses 5977 5977
Partials 671 671 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 53.12% 53.14% +0.01%
==========================================
Files 95 95
Lines 14183 14188 +5
==========================================
+ Hits 7535 7540 +5
Misses 5977 5977
Partials 671 671 |
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 53.12% 53.15% +0.03%
==========================================
Files 95 95
Lines 14183 14188 +5
==========================================
+ Hits 7535 7542 +7
+ Misses 5977 5976 -1
+ Partials 671 670 -1 |
@JunSun17 I believe we can do this in a different way. Since |
@tariq1890 I do not quite understand, can you elaborate what field you are proposing to disable the addon. Please also note, the IP-MASQ-AGENT for aks engine has already been done by @jackfrancis . However, AKS is handling addon differently, and this PR mainly adds a toggle for AKS to turn on/off this feature. |
/lgtm |
@JunSun17 Makes sense. Thanks for the clarification :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JunSun17, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit 4ace5af.
* Add toggle for switching ip-masq-agent logic for AKS. * Add unit tests.
Add toggle for switching ip-masq-agent logic for AKS. This way, the AKS-engine code can be checked in first. Later when AKS turn on the toggle, it should activate this feature.