Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: Azure DevOps PR E2E pipeline #135

Merged
merged 33 commits into from
Jan 3, 2019
Merged

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Dec 13, 2018

What this PR does / why we need it: Add E2E with Azure DevOps pipeline to eventually replace circle CI.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@CecileRobertMichon CecileRobertMichon changed the title WIP Azure DevOps PR E2E pipeline [WIP] Azure DevOps PR E2E pipeline Dec 13, 2018
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #135   +/-   ##
======================================
  Coverage    53.2%   53.2%           
======================================
  Files          95      95           
  Lines       14235   14235           
======================================
  Hits         7574    7574           
  Misses       5995    5995           
  Partials      666     666

@CecileRobertMichon
Copy link
Contributor Author

NOTE: after this PR is merged, we need to update the VHD pipeline yaml path in Azure DevOps since I renamed the file .vsts-ci.yaml → .pipelines/vhd-builder.yaml

@CecileRobertMichon CecileRobertMichon changed the title [WIP] Azure DevOps PR E2E pipeline Azure DevOps PR E2E pipeline Dec 14, 2018
@CecileRobertMichon
Copy link
Contributor Author

installing sudo is failing as described in dotnet/dotnet-docker#788... I think we need sudo in the image, or get rid of install kubectl altogether and put that in the image.

@mboersma mboersma changed the title Azure DevOps PR E2E pipeline [WIP] Azure DevOps PR E2E pipeline Dec 19, 2018
@jackfrancis jackfrancis added this to In progress in backlog Dec 19, 2018
@mboersma mboersma changed the title [WIP] Azure DevOps PR E2E pipeline [WIP] feat: Azure DevOps PR E2E pipeline Dec 31, 2018
@CecileRobertMichon CecileRobertMichon changed the title [WIP] feat: Azure DevOps PR E2E pipeline feat: Azure DevOps PR E2E pipeline Jan 2, 2019
@mboersma
Copy link
Member

mboersma commented Jan 2, 2019

/lgtm

@acs-bot acs-bot added the lgtm label Jan 2, 2019
@CecileRobertMichon CecileRobertMichon added this to the v0.29.0 milestone Jan 2, 2019
@jackfrancis
Copy link
Member

/lgtm


- template: e2e-job-template.yaml
parameters:
name: 'k8s_1dot10_release_e2e'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we have an underscore instead of dot? More readable that way IMO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't like "dot" I vote for a period (.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

period isn't a valid char in the name (that was my first choice too)

I can change it to underscore


- template: e2e-job-template.yaml
parameters:
name: 'k8s_1dot10_release_e2e'
Copy link
Contributor

@tariq1890 tariq1890 Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'k8s_1dot10_release_e2e'
name: 'k8s_1_10_release_e2e'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the extra space?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Edited the suggestion

@acs-bot acs-bot removed the lgtm label Jan 3, 2019
@tariq1890
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,mboersma,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon CecileRobertMichon merged commit bc25013 into master Jan 3, 2019
backlog automation moved this from In progress to Done Jan 3, 2019
@CecileRobertMichon CecileRobertMichon deleted the pr-e2e-pipeline branch January 3, 2019 01:13
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants