-
Notifications
You must be signed in to change notification settings - Fork 523
Conversation
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
======================================
Coverage 53.2% 53.2%
======================================
Files 95 95
Lines 14235 14235
======================================
Hits 7574 7574
Misses 5995 5995
Partials 666 666 |
NOTE: after this PR is merged, we need to update the VHD pipeline yaml path in Azure DevOps since I renamed the file .vsts-ci.yaml → .pipelines/vhd-builder.yaml |
5a2d273
to
875b1dc
Compare
installing sudo is failing as described in dotnet/dotnet-docker#788... I think we need sudo in the image, or get rid of install kubectl altogether and put that in the image. |
50b7b3b
to
a0dec60
Compare
/lgtm |
/lgtm |
.pipelines/pr-e2e.yaml
Outdated
|
||
- template: e2e-job-template.yaml | ||
parameters: | ||
name: 'k8s_1dot10_release_e2e' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we have an underscore instead of dot
? More readable that way IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't like "dot" I vote for a period (.
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
period isn't a valid char in the name (that was my first choice too)
I can change it to underscore
.pipelines/pr-e2e.yaml
Outdated
|
||
- template: e2e-job-template.yaml | ||
parameters: | ||
name: 'k8s_1dot10_release_e2e' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: 'k8s_1dot10_release_e2e' | |
name: 'k8s_1_10_release_e2e' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the extra space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Edited the suggestion
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, mboersma, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Add E2E with Azure DevOps pipeline to eventually replace circle CI.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: