Conversation
This allows the cluster-autoscaler to evict the pods of the concerned deployments. Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
Coverage ? 53.2%
========================================
Files ? 95
Lines ? 14235
Branches ? 0
========================================
Hits ? 7574
Misses ? 5995
Partials ? 666 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
Coverage ? 53.2%
========================================
Files ? 95
Lines ? 14235
Branches ? 0
========================================
Hits ? 7574
Misses ? 5995
Partials ? 666 |
@sylr Thanks for this! FYI I rebased/force pushed to enable our new E2E pipeline to run. |
name: calico-typha | ||
namespace: kube-system | ||
spec: | ||
minAvailable: 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sort of seems like a no-op configuration, but I infer that cluster-autoscaler needs some value here in order to engage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. The cluster-autoscaler will refuse to engage in a node scale down if there are non-mirrored pods which do not have a PDB that allows the pod to be killed.
/lgtm |
@mboersma, could you spend a small amount of time reading up on the PodDisruptionBudget spec and sanity check the functional intent here. LGTM but I'd like a 2nd opinion. :) |
/lgtm based on my reading of the cluster-autoscaler FAQ and the CA docs. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma, sylr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This allows the cluster-autoscaler to evict the pods of the concerned deployments. Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
Reason for Change:
This allows the cluster-autoscaler to evict the pods of the concerned deployments.
Issue Fixed:
Requirements:
Notes: Add pod disruption budgets