This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: override components command config during upgrade #2814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR enforces component command configuration override during upgrade, which is documented here:
https://github.com/Azure/aks-engine/blob/master/docs/topics/clusterdefinitions.md#components
Specifically:
We would be true to the above documentation to statically override all configuraiton key/vals in an upgrade flow, but in the event that we want to enable some subset of the components container configuration to be user-configurable across upgrade, this PR only enforces the config override for the "command" config, which is the only config key that our yaml manifests currently recognize.
Issue Fixed:
Requirements:
Notes: