Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: override components command config during upgrade #2814

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR enforces component command configuration override during upgrade, which is documented here:

https://github.com/Azure/aks-engine/blob/master/docs/topics/clusterdefinitions.md#components

Specifically:

this configurable vector is designed for cluster creation only. Using aks-engine upgrade on a cluster will override the original, user-configured settings during the upgrade operation, rendering an upgraded cluster with the AKS Engine defaults for kube-controller-manager, cloud-controller-manager, kube-apiserver, kube-scheduler, and kube-addon-manager.

We would be true to the above documentation to statically override all configuraiton key/vals in an upgrade flow, but in the event that we want to enable some subset of the components container configuration to be user-configurable across upgrade, this PR only enforces the config override for the "command" config, which is the only config key that our yaml manifests currently recognize.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #2814 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
+ Coverage   72.35%   72.43%   +0.07%     
==========================================
  Files         137      140       +3     
  Lines       25339    25550     +211     
==========================================
+ Hits        18333    18506     +173     
- Misses       5949     5976      +27     
- Partials     1057     1068      +11     
Impacted Files Coverage Δ
pkg/armhelpers/azurestack/httpMockClient.go 61.46% <0.00%> (-0.25%) ⬇️
pkg/armhelpers/mockclients.go 22.61% <0.00%> (-0.14%) ⬇️
pkg/armhelpers/httpMockClient.go 58.71% <0.00%> (-0.13%) ⬇️
pkg/helpers/azure_locations.go 100.00% <0.00%> (ø) ⬆️
pkg/armhelpers/subscriptions.go 60.00% <0.00%> (ø)
pkg/armhelpers/azurestack/subscriptions.go 60.00% <0.00%> (ø)
cmd/get_locations.go 87.34% <0.00%> (ø)
pkg/api/addons.go 97.61% <0.00%> (+0.01%) ⬆️
pkg/armhelpers/azurestack/azureclient.go 29.46% <0.00%> (+0.64%) ⬆️
pkg/armhelpers/azureclient.go 35.27% <0.00%> (+0.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd077c...1afd02c. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit eb8129d into Azure:master Mar 2, 2020
@jackfrancis jackfrancis deleted the components-override-command-upgrade branch March 2, 2020 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants