Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: check network from node to k8s api server in CSE #2919

Merged
merged 2 commits into from Mar 19, 2020
Merged

fix: check network from node to k8s api server in CSE #2919

merged 2 commits into from Mar 19, 2020

Conversation

bowang-666
Copy link
Contributor

Reason for Change:

Sometimes agent nodes can not reach k8s api server due to custom network settings. It will cause "nodenotready" failures during create/scale/upgrade. This pr will check the connection from node to k8s api and raise error code if can't connect.

Issue Fixed:

Requirements:

Notes:

@welcome
Copy link

welcome bot commented Mar 18, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/S label Mar 18, 2020
@bowang-666 bowang-666 changed the title Check network from node to k8s api server in CSE Fix: Check network from node to k8s api server in CSE Mar 18, 2020
@bowang-666 bowang-666 changed the title Fix: Check network from node to k8s api server in CSE fix: check network from node to k8s api server in CSE Mar 18, 2020
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

xuto2
xuto2 previously approved these changes Mar 18, 2020
View reviewed changes
@jackfrancis
Copy link
Member

Run make generate and commit generated code to pass unit test lint.

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2919 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2919      +/-   ##
==========================================
- Coverage   72.53%   72.49%   -0.04%     
==========================================
  Files         141      141              
  Lines       25776    25847      +71     
==========================================
+ Hits        18696    18739      +43     
- Misses       5999     6021      +22     
- Partials     1081     1087       +6

@bowang-666 bowang-666 requested a review from xuto2 March 18, 2020 23:30
@xuto2
Copy link
Contributor

xuto2 commented Mar 18, 2020

/lgtm

@acs-bot acs-bot added the lgtm label Mar 18, 2020
jackfrancis
jackfrancis approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit b001325 into Azure:master Mar 19, 2020
@welcome
Copy link

welcome bot commented Mar 19, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented Mar 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowang-666, jackfrancis, xuto2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bowang-666 added a commit to bowang-666/aks-engine that referenced this pull request Mar 19, 2020
@bowang-666
fix: check network from node to k8s api server in CSE (Azure#2919)
c70cdd1
@bowang-666 bowang-666 mentioned this pull request Mar 19, 2020
Merged
4 tasks
@fmotrifork fmotrifork mentioned this pull request Mar 23, 2020
Merged
bowang-666 added a commit to bowang-666/aks-engine that referenced this pull request Mar 25, 2020
@bowang-666
fix: check network from node to k8s api server in CSE (Azure#2919)
8cad150
xuto2 pushed a commit that referenced this pull request Mar 26, 2020
@bowang-666
Cherry pick: check network to k8s api server (#2965)
2c82d69 
* fix: check network from node to k8s api server in CSE (#2919)

* cherrypick: check network to k8s api server
bowang-666 added a commit to bowang-666/aks-engine that referenced this pull request Apr 1, 2020
@bowang-666
fix: check network from node to k8s api server in CSE (Azure#2919)
e696f54
xuto2 pushed a commit that referenced this pull request Apr 1, 2020
@bowang-666
cherry-pick: check dns and network connection in cse (#3008)
64cada8 
* fix: check network from node to k8s api server in CSE (#2919)

* fix: check network to k8s api for vmss (#2938)

* fix: check dns status before connection (#3002)

Co-authored-by: Bo Wang <bowa@microsoft.com>

Co-authored-by: Bo Wang <bowa@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@xuto2 xuto2 Awaiting requested review from xuto2

Assignees

@xuto2 xuto2

@jackfrancis jackfrancis

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bowang-666 @jackfrancis @xuto2 @acs-bot