Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: use hotfix Windows builds for 1.18.4, 1.17.7, and 1.16.11 #3510

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Jun 19, 2020

Reason for Change:

This PR brings in metrics-server hotfixes for Windows builds of Kubernetes 1.18.4, 1.17.7, and 1.16.11.

Issue Fixed:

Requirements:

Notes:

@marosset
Copy link
Contributor

/lgtm

@marosset
Copy link
Contributor

kubernetes/kubernetes#90554 is the change that is getting hotfixed

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #3510 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3510      +/-   ##
==========================================
+ Coverage   73.16%   73.17%   +0.01%     
==========================================
  Files         147      147              
  Lines       25051    25065      +14     
==========================================
+ Hits        18328    18342      +14     
  Misses       5589     5589              
  Partials     1134     1134              
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc3d52...cffa6e0. Read the comment docs.

@marosset
Copy link
Contributor

@AbelHu @mikkelhegn @keikhara FYI

I validated that when 1.16.11 was specified the hotfixed binaries were used on the Windows nodes.

@marosset
Copy link
Contributor

Also @jadarsie @haofan-ms as FYI.
These hotfixes just include kubernetes/kubernetes#90554

@marosset marosset merged commit c4752c4 into Azure:master Jun 19, 2020
@acs-bot
Copy link

acs-bot commented Jun 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis deleted the windows-hotfixes branch June 20, 2020 15:26
AbelHu added a commit to AbelHu/aks-engine that referenced this pull request Jun 27, 2020
…0 and 1.15.12

From below commits in master branch:
1. fix: use hotfix Windows builds for 1.18.4, 1.17.7, and
1.16.11 (Azure#3510)
2. fix: add windows hotfix overrides for 1.18.2, 1.16.10, 1.15.12 for
AKS (Azure#3528)
3. fix: updating hotfix packages used for windows to include hyperkube
and iptables fixes (Azure#3539)
AbelHu added a commit that referenced this pull request Jun 28, 2020
…0 and 1.15.12

From below commits in master branch:
1. fix: use hotfix Windows builds for 1.18.4, 1.17.7, and
1.16.11 (#3510)
2. fix: add windows hotfix overrides for 1.18.2, 1.16.10, 1.15.12 for
AKS (#3528)
3. fix: updating hotfix packages used for windows to include hyperkube
and iptables fixes (#3539)
AbelHu added a commit that referenced this pull request Jun 28, 2020
…ckages (#3554)

* chore: updating windows VHD used by aks-engine to include June k8s packages (#3550)

* use hotfix Windows builds for 1.18.4, 1.18.2, 1.17.7, 1.16.11, 1.16.10 and 1.15.12

From below commits in master branch:
1. fix: use hotfix Windows builds for 1.18.4, 1.17.7, and
1.16.11 (#3510)
2. fix: add windows hotfix overrides for 1.18.2, 1.16.10, 1.15.12 for
AKS (#3528)
3. fix: updating hotfix packages used for windows to include hyperkube
and iptables fixes (#3539)

* Update PauseImage to 1.4.0 for Windows

From below commits in master branch
1. chore: Updates the pause image to 1.4.0 (#3516)

Co-authored-by: Mark Rossetti <marosset@microsoft.com>
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants