Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Use moby 19.03.x packages #3549

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Conversation

cpuguy83
Copy link
Member

Reason for Change:

Update moby verison.

Issue Fixed:

N/A

Requirements:

Notes:

This is the same as 3.0.13, except the new versioning to match upstream
and things are packaged differently (e.g. containerd is now managed with
systemd instead of by dockerd).
The packaging/build changes are fairly significant, but the underlying
moby commits are the same.

@acs-bot acs-bot added the size/S label Jun 26, 2020
@cpuguy83
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #3549 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3549   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files         147      147           
  Lines       25122    25122           
=======================================
  Hits        18385    18385           
  Misses       5605     5605           
  Partials     1132     1132           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 53.61% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cfdaa7...0394067. Read the comment docs.

@cpuguy83
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cpuguy83
Copy link
Member Author

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cpuguy83
Copy link
Member Author

cpuguy83 commented Jul 3, 2020

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This is the same as 3.0.13, except the new versioning to match upstream
and things are packaged differently (e.g. containerd is now managed with
systemd instead of by dockerd).
The packaging/build changes are fairly significant, but the underlying
moby commits are the same.
@cpuguy83 cpuguy83 changed the title chore: Use moby 19.03.11 chore: Use moby 19.03.x packages Jul 8, 2020
This just ensures that docker is started after it is installed.
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Jul 9, 2020
@jackfrancis jackfrancis merged commit a43f825 into Azure:master Jul 9, 2020
@acs-bot
Copy link

acs-bot commented Jul 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpuguy83, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpuguy83 cpuguy83 deleted the moby_19.03.11 branch July 9, 2020 19:44
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants