-
Notifications
You must be signed in to change notification settings - Fork 522
fix: add rbac rules for nodes/status in cloud-node-manager.yaml #3699
Conversation
e3c44b7
to
d68e302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
That describes what this PR does, but isn't a reason: why do we need to add this RBAC permission? It's not in the example manifest at kubernetes-sigs/cloud-provider-azure, so I'm just curious why the change is needed. |
kubernetes-sigs/cloud-provider-azure#372 the PR is adding it in the example manifest. We need this because it blocks several of our tests in here. |
/lgtm |
d68e302
to
434245c
Compare
No pipelines are associated with this pull request. |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run pr-e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #3699 +/- ##
=======================================
Coverage 73.16% 73.16%
=======================================
Files 147 147
Lines 25318 25318
=======================================
Hits 18525 18525
Misses 5655 5655
Partials 1138 1138
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, feiskyer, mboersma, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Add rbac rules for nodes/status in cloud-node-manager.yaml.
Issue Fixed:
Requirements:
Notes: