Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Add support for low pri scalesets in windows agents #378

Merged
merged 1 commit into from Jan 25, 2019

Conversation

tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Jan 24, 2019

Why should windows miss out on the fun ;)

cc @asw101

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   53.41%   53.41%           
=======================================
  Files          95       95           
  Lines       14271    14271           
=======================================
  Hits         7623     7623           
  Misses       5986     5986           
  Partials      662      662

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Jan 24, 2019

@tariq1890 did you try a deployment with windows + ScaleSetPriority = "Low" and verify the result?

code lgtm

@tariq1890
Copy link
Contributor Author

I haven't. I will try that

@tariq1890
Copy link
Contributor Author

@CecileRobertMichon I can confirm that this works

@CecileRobertMichon
Copy link
Contributor

/lgtm

@jackfrancis
Copy link
Member

/lgtm

@tariq1890 tariq1890 merged commit 6389bd9 into Azure:master Jan 25, 2019
@tariq1890 tariq1890 deleted the low_pri branch January 25, 2019 00:37
@acs-bot
Copy link

acs-bot commented Jan 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickLang
Copy link
Contributor

sure - nothing Windows specific here. If it passes CI with those set in the API model then LGTM

@tariq1890
Copy link
Contributor Author

Thanks @PatrickLang !

juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants