fix: Add support for low pri scalesets in windows agents #378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 53.41% 53.41%
=======================================
Files 95 95
Lines 14271 14271
=======================================
Hits 7623 7623
Misses 5986 5986
Partials 662 662 |
@tariq1890 did you try a deployment with windows + ScaleSetPriority = "Low" and verify the result? code lgtm |
I haven't. I will try that |
@CecileRobertMichon I can confirm that this works |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sure - nothing Windows specific here. If it passes CI with those set in the API model then LGTM |
Thanks @PatrickLang ! |
Why should windows miss out on the fun ;)
cc @asw101