This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
ci: Windows VHD pipeline tests #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
changed the title
AbelHu
reviewed
Oct 28, 2020
vhd/packer/sysprep.ps1
Outdated
| @@ -0,0 +1,38 @@ | |||
| # Stop and remove Azure Agents to enable use in Azure Stack | |||
| # If deployed in azure vm the agents will be added to the vms at deployment time | |||
There was a problem hiding this comment.
We only want to stop DiagTrack in the pause image which is being done in: kubernetes/kubernetes#95950
AbelHu
reviewed
Oct 28, 2020
jsturtevant
force-pushed
the
fix/windows-e2e
branch
from
2ec3a79
to
e72a629
Compare
marosset
reviewed
Oct 28, 2020
| @@ -0,0 +1,36 @@ | |||
| # Stop and remove Azure Agents to enable use in Azure Stack | |||
There was a problem hiding this comment.
Thanks for pulling this out into a separate script!
jsturtevant
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 tasks
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
* disabling managed identity for windows vhd build make test-kubernetes step * Disable Azure Agents and remove from sysprep Co-authored-by: marosset <marosset@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR unblocks the Windows VHD scripts by doing two things:
azure-arm: IMAGE_STATE_UNDEPLOYABLE - missing VMAgentDisabler.dll.The VM agent doesn't do anything during sysprep so it is ok to remove it. If the image is deployed to Azure as a VM the agent will redeployed.USE_MANAGED_IDENTITY=falseIssue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: