Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: add retry when downloading files in windows CSE #4232

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Feb 4, 2021

Reason for Change:

Replicating #4206 for the Windows CSE

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jsturtevant
Copy link
Contributor

there are a few other places as well: https://github.com/Azure/aks-engine/search?q=Invoke-webrequest

Might as well get them all 😄

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #4232 (c7398ed) into master (f5836e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4232   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       21698    21698           
=======================================
  Hits        15638    15638           
  Misses       5103     5103           
  Partials      957      957           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5836e0...c7398ed. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit e36228f into Azure:master Feb 5, 2021
@acs-bot
Copy link

acs-bot commented Feb 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants