Idle-Timeout communicated in open frame #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #238 |
|
Also includes change to heartbeat frequency based on idle timeout parameter received. Now sets heartbeat frequency to half of timeout, as suggested in AMQP spec. Previously 3000 ms were subtracted. This could be an issue for low timeouts and with connections with high latency (if it takes more than 3s to send the heartbeat over the wire). Communicating at half of the idle timeout removes these issues and gives the developer more control. |
xinchen10
reviewed
Nov 29, 2017
src/Net/AmqpSettings.cs
Outdated
| @@ -70,7 +70,7 @@ public int MaxLinksPerSession | |||
| /// <summary> | |||
| /// Gets or sets the open.idle-time-out field. | |||
| /// </summary> | |||
| public int IdleTimeout | |||
| public uint IdleTimeout | |||
There was a problem hiding this comment.
A property type change is potentially a breaking change so let's keep it as int. In OnOpen there is max value check so it should be able to handle any received idle timeout value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.